Skip to content

python: update readline to 8.1#203651

Closed
tjni wants to merge 1 commit intoNixOS:stagingfrom
tjni:python-readline
Closed

python: update readline to 8.1#203651
tjni wants to merge 1 commit intoNixOS:stagingfrom
tjni:python-readline

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Nov 29, 2022

The Python interpreter crashes on Darwin when the terminal is resized when it's built using readline 6.3.

It's enough to update to readline 7.0 (in fact, readline 7.0-alpha), but it doesn't seem easy to bisect further as the public GNU readline repository does not contain individual commits.

This can be replaced by #151090, or it can be committed first. It addresses #151090 (comment) and fixes #203376.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Contributor Author

tjni commented Nov 29, 2022

@ofborg build python27, python37, python38, python39, python310, python311

The Python interpreter crashes on Darwin when the terminal is resized
when it's built using readline 6.3.
@tjni
Copy link
Contributor Author

tjni commented Nov 29, 2022

@ofborg build python27, python37, python38, python39, python310, python311

@ofborg ofborg bot requested review from SuperSandro2000 and adevress November 29, 2022 20:33
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 29, 2022
@SuperSandro2000
Copy link
Member

I merged the linked PR. Lets see how that goes.

@tjni
Copy link
Contributor Author

tjni commented Nov 30, 2022

Thank you! I'll close this for now to reduce chance of confusion.

@tjni tjni closed this Nov 30, 2022
@tjni tjni deleted the python-readline branch November 30, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants