Skip to content

glibc: bump the minimum kernel version#202827

Merged
veprbl merged 1 commit intoNixOS:stagingfrom
vcunat:p/glibc-kernel-versions
Dec 3, 2022
Merged

glibc: bump the minimum kernel version#202827
veprbl merged 1 commit intoNixOS:stagingfrom
vcunat:p/glibc-kernel-versions

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Nov 25, 2022

I don't think anyone sane is really using kernel < 3.10 nowadays. (At least in a use case with glibc from nixpkgs.)

As another suspect with old kernels, Ubuntu seems to start at 3.13 now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

I don't think anyone sane is really using kernel < 3.10 nowadays.
(At least in a use case with glibc from nixpkgs.)

As another suspect with old kernels, Ubuntu seems to start at 3.13 now.
@vcunat vcunat requested review from Ma27 and veprbl November 25, 2022 10:49
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but I'd like to await a response from @veprbl first :)

@vcunat
Copy link
Member Author

vcunat commented Nov 25, 2022

Part of this was done in PR #188492, but I think this is worth a separate PR. It's quite an unrelated question to discuss, and much simpler to decide and merge (no packages should be affected).

I waited until after 22.11 got forked off, so that also gives some buffer to any stragglers on old systems.

@Ma27
Copy link
Member

Ma27 commented Nov 25, 2022

Part of this was done in PR #188492, but I think this is worth a separate PR

Yep, but the PR in question is quite far from being mergable, so whoever's interested in that for whatever reason would have a lot of time to respond in that case ;-)

I waited until after 22.11 got forked off, so that also gives some buffer to any stragglers on old systems.

Yeah, if we get no response soonish, I'd be fine with merging, just wanted to point out that we should perhaps wait for a bit :)

@ofborg ofborg bot added the 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. label Nov 25, 2022
@ofborg ofborg bot requested review from Ma27 and edolstra November 25, 2022 12:14
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 25, 2022
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is wrong with the patches for RHEL6 kernel support, but I think it's fine to remove them now.

@vcunat
Copy link
Member Author

vcunat commented Nov 26, 2022

I'm not aware of anything wrong. Just that RHEL 6 seemed not relevant anymore, and that's why I thought it possible to do this cleanup and raise kernel versions (RHEL 6 has heavily patched 2.6.32 kernel).

@mweinelt mweinelt added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Dec 3, 2022
@veprbl veprbl merged commit 68e63f0 into NixOS:staging Dec 3, 2022
@vcunat vcunat deleted the p/glibc-kernel-versions branch December 4, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants