workflows/backport-action 0.0.8 -> 0.0.9#202500
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Nov 27, 2022
Merged
Conversation
github-actions
bot
added
the
6.topic: policy discussion
ofborg
bot
added
10.rebuild-darwin: 0
LeSuisse
reviewed
Nov 27, 2022
Member
LeSuisse
left a comment
LeSuisse
left a comment
There was a problem hiding this comment.
Changes looks fine and upstream changelog looks also fine.
| ref: ${{ github.event.pull_request.head.sha }} | ||
| - name: Create backport PRs | ||
| uses: zeebe-io/backport-action@v0.0.8 | ||
| uses: zeebe-io/backport-action@v0.0.9 |
Member
There was a problem hiding this comment.
Suggested change
| uses: zeebe-io/backport-action@v0.0.9 | |
| uses: zeebe-io/backport-action@2ee900dc92632adf994f8e437b6d16840fd61f58 # tag=v0.0.9 |
How do you feel about pinning the action to the specific commit?
This could help in the situation where the upstream repository of the action is compromised is some ways (especially since the job has some write permissions).
Member
There was a problem hiding this comment.
It looks like this has already been discussed in #140301, sorry for the noise and feel free to disregard my comment. Dependabot support has however been improved since then and updating the commit reference and the associated comment is not an issue anymore (see dependabot/dependabot-core#5951)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/zeebe-io/backport-action/releases/tag/v0.0.9
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes