Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swww: init at 0.7.2 #202280

Merged
merged 11 commits into from
Mar 9, 2023
Merged

swww: init at 0.7.2 #202280

merged 11 commits into from
Mar 9, 2023

Conversation

mateodd25
Copy link
Contributor

@mateodd25 mateodd25 commented Nov 22, 2022 •
edited
Loading

Description of changes

Added swww, a package to change the wallpaper on wayland. See https://github.com/Horus645/swww for more details.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 22, 2022
@rsHalford
Copy link

Before merging this, could it get bumped to v0.6.0, please? Hopefully this gets merged soon!

@rsHalford rsHalford mentioned this pull request Dec 31, 2022
Closed
@IogaMaster
Copy link
Contributor

Please merge this

@IogaMaster
Copy link
Contributor

I have created a basic flake for swww:
https://github.com/IogaMaster/swww-nix

@GlancingMind
Copy link
Contributor

Swww just got a new release. https://github.com/Horus645/swww/releases/tag/v0.7.0

@IogaMaster
Copy link
Contributor

Alright I have bumped it to v0.7.0

@mateodd25 mateodd25 changed the title swww: init at 0.5.0 swww: init at 0.7.0 Feb 4, 2023
@mateodd25
Copy link
Contributor Author

Updated to v0.7.0. I also hope this gets merged soon.

ocfox
ocfox reviewed Feb 4, 2023
View reviewed changes
Copy link
Member

@ocfox ocfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding blank lines after the 12 and 16 lines.

adamcstephens
adamcstephens requested changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@adamcstephens adamcstephens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more whitespace would be nice.

The version in the tag is also mismatched with the release version.

./result/bin/swww --version
swww 0.6.0

LGFae/swww@d2f3570#comments

pkgs/tools/wayland/swww/default.nix Outdated Show resolved Hide resolved
pkgs/tools/wayland/swww/default.nix Outdated Show resolved Hide resolved
pkgs/tools/wayland/swww/default.nix Show resolved Hide resolved
pkgs/tools/wayland/swww/default.nix Outdated Show resolved Hide resolved
pkgs/tools/wayland/swww/default.nix Outdated Show resolved Hide resolved
@mateodd25
Copy link
Contributor Author

Some more whitespace would be nice.

Done.

The version in the tag is also mismatched with the release version.

./result/bin/swww --version
swww 0.6.0

Horus645/swww@d2f3570#comments

This should be fixed with release v0.7.1 (which, according to @Horus645, should be fairly soon). Should I wait for it or change the version to v0.6.0 and use the commit hash for rev?

@LGFae
Copy link

LGFae commented Feb 4, 2023

This should be fixed with release v0.7.1 (which, according to @Horus645, should be fairly soon). Should I wait for it or change the version to v0.6.0 and use the commit hash for rev?

I am planning the new release for tomorrow, so you might want to wait one more day

@adamcstephens
Copy link
Contributor

adamcstephens commented Feb 4, 2023 •
edited
Loading

Result of nixpkgs-review pr 202280 run on x86_64-linux 1

1 package built:
  • swww

Result of nixpkgs-review pr 202280 run on aarch64-linux 1

1 package failed to build:
  • swww

LGFae/swww#59

Looks like aarch64 may need rustc 1.67.0, which is merged (#212811) but not yet available in master.

I'd probably wait for the newer rustc and see if swww 0.7.1 is out by then.

@mateodd25
Copy link
Contributor Author

Sounds good. I don't have a computer with aarch64, so I cannot try it. But I am happy to wait if it means swww will reach more users.

@IogaMaster
Copy link
Contributor

I bumped my flake to v0.7.1.

@adamcstephens
Copy link
Contributor

@mateodd25 This now builds as rustc 1.67.0 is in master. Do you want to bump this PR to 0.7.1 and we can try and move forward?

@GlancingMind
Copy link
Contributor

Another minor release dropped: https://github.com/Horus645/swww/releases/tag/v0.7.2

@IogaMaster
Copy link
Contributor

I bumped my flake to v0.7.2

@mateodd25 mateodd25 changed the title swww: init at 0.7.0 swww: init at 0.7.2 Feb 19, 2023
@mateodd25
Copy link
Contributor Author

@adamcstephens Sorry for the delay; I was busy this week. I updated to v0.7.2. Let's go ahead and move forward.

adamcstephens
adamcstephens approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 202280 run on x86_64-linux 1

1 package built:
  • swww

Result of nixpkgs-review pr 202280 run on aarch64-linux 1

1 package built:
  • swww

@adamcstephens adamcstephens added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 20, 2023
@mateodd25
Copy link
Contributor Author

Sorry, I am not sure what the protocol is here. But what is missing for this PR to get merged?

@arjan-s
Copy link
Contributor

arjan-s commented Mar 4, 2023

Result of nixpkgs-review pr 202280 run on x86_64-linux 1

1 package built:
  • swww

@NobbZ NobbZ merged commit d8179d8 into NixOS:master Mar 9, 2023
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocfox ocfox ocfox approved these changes

@arjan-s arjan-s arjan-s approved these changes

@robertodr robertodr robertodr approved these changes

@adamcstephens adamcstephens adamcstephens approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.