nixos/profiles/base: install vim w/nix-syntax plugin

[Ma27]

Description of changes

Considering that you most likely edit Nix code in the installer, that seems like a useful thing.

The size of the ISO I got from

nix-build nixos/release.nix -A iso_minimal.x86_64-linux

is still at 877M.

As suggested by @madonius.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1469

[SuperSandro2000]

this should help people a lot in creating less syntax errors

[teto]

+1 on the intention but the growth in size is too much. vim and vim_configurable must have different compilation flags. Could you reduce it ? how much would it be with neovim (just curious) ?

[jsoo1]

I still think the best thing to do is to upstream nix syntax highlighting to the vim tree.

See here LnL7/vim-nix#47

I'm mostly waiting on some word from LnL7 if they would be alright letting someone take over maintenance of the syntax definitions.

Or maybe the definitions could be added to the community repos or the official repos even as point of contact for vim maintainers.

[jsoo1]

Opened vim/vim#11646

[Ma27]

@ncfavier TIL, thanks! Indeed, this doesn't cause a significant increase of size, we're still at 877M now.

I'd be in favor of merging it, we can still remove it again if vim actually includes Nix integration.

[ncfavier]

Backports: #204307 #204313