Skip to content

exercism: init at 2.3.0#20106

Merged
fpletz merged 2 commits intoNixOS:masterfrom
rbasso:exercism-init-at-2.3.0
Nov 3, 2016
Merged

exercism: init at 2.3.0#20106
fpletz merged 2 commits intoNixOS:masterfrom
rbasso:exercism-init-at-2.3.0

Conversation

@rbasso
Copy link
Contributor

@rbasso rbasso commented Nov 2, 2016

Hi!

I'm new to Nix and this is my first PR here, so please be extra-cautious.

Motivation for this change

This package was accidentally removed from nixpkgs by #16017, as mentioned in #19597 (comment).

Considering that the removed version was more than a year old, I decided to rewrite it from scratch using the latest release.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" n/a
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fixes #19597.

@mention-bot
Copy link

@rbasso, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @edolstra to be potential reviewers.

@fpletz fpletz merged commit 9b3da61 into NixOS:master Nov 3, 2016
@rbasso rbasso deleted the exercism-init-at-2.3.0 branch November 3, 2016 06:22
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Was exercism dropped from nixpkgs?

5 participants