Skip to content

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Nov 13, 2022

Description of changes

https://github.com/Textualize/rich/blob/master/CHANGELOG.md#1260---2022-10-02

Needed by #198533.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni requested review from FRidh and jonringer as code owners November 13, 2022 16:02
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 13, 2022
@ofborg ofborg bot requested review from jyooru and risicle November 13, 2022 16:22
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 13, 2022
@tjni tjni changed the base branch from master to staging November 13, 2022 16:24
@risicle
Copy link
Contributor

risicle commented Nov 13, 2022

@ofborg eval

passthru.tests build for me, aarch64-linux & macos 10.15

Copy link
Member

@jyooru jyooru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rich-cli works on x86_64-linux

@ofborg ofborg bot requested a review from jyooru November 16, 2022 10:29
@risicle risicle merged commit 524f441 into NixOS:staging Nov 16, 2022
@tjni tjni deleted the rich-update branch November 16, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants