pixman: fixing aarch64-darwin build

[vcunat]

https://hydra.nixos.org/build/197830077

Things done

• Built on platform(s)
  • no rebuild x86_64-linux
  • no rebuild aarch64-linux
  • no rebuild x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[vcunat]

@ofborg build pixman

[vcunat]

I doesn't work :-(

[vcunat]

I suppose in the worst case we could split aarch64-darwin away, using the older version with security patch (we patch on 22.05).

[sternenseemann]

Probably because gccStdenv has this:

      # Remove libcxx/libcxxabi, and add clang for AS if on darwin (it uses
      # clang's internal assembler).
      extraBuildInputs = lib.optional stdenv.hostPlatform.isDarwin clang.cc;

If the gcc assembler can't work on darwin, it seems like we would need to downgrade.

[vcunat]

@ofborg build pixman

[sternenseemann]

FWIW the gccStdenv stuff was put together in 2017 (including using clang for AS), so who knows how it should be today: a5168fe

[vcunat]

@ofborg build pixman

[vcunat]

Still doesn't seem to work: https://logs.nix.ci/?key=nixos/nixpkgs.200156&attempt_id=2cc36828-c17d-42ed-84cc-2c87f908a937

[vcunat]

I haven't tried this one:
@ofborg build pixman

[vcunat]

But really... someone actually interested in aarch64-darwin should be solving such problems.

[vcunat]

https://logs.nix.ci/?key=nixos/nixpkgs.200156&attempt_id=8beea391-ccbf-476c-be0f-e6351f6cadeb
I guess I'm giving up 🤷🏽

[reckenrode]

I was able to get it to build by disabling ARM64 Neon on aarch64-darwin. This is using the default, clang-based stdenv.

diff --git a/pkgs/development/libraries/pixman/default.nix b/pkgs/development/libraries/pixman/default.nix
index 49f5fbe8815..bd807d603cb 100644
--- a/pkgs/development/libraries/pixman/default.nix
+++ b/pkgs/development/libraries/pixman/default.nix
@@ -18,7 +18,9 @@ stdenv.mkDerivation rec {
 
   buildInputs = [ libpng ];
 
-  configureFlags = lib.optional stdenv.isAarch32 "--disable-arm-iwmmxt";
+  configureFlags = lib.optional stdenv.isAarch32 "--disable-arm-iwmmxt"
+   # Disable until https://gitlab.freedesktop.org/pixman/pixman/-/issues/46 is resolved
+   ++ lib.optional (stdenv.isAarch64 && !stdenv.cc.isGNU) "--disable-arm-a64-neon";
 
   preConfigure = ''
     # https://gitlab.freedesktop.org/pixman/pixman/-/issues/62

[vcunat]

@ofborg build pixman

[vcunat]

Thanks. OfBorg confirmed success, so I pushed it there with you as author.