Skip to content

python3Packages.sh: disable flaky tests#199441

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
wegank:sh-aarch64-darwin
Nov 7, 2022
Merged

python3Packages.sh: disable flaky tests#199441
mweinelt merged 1 commit intoNixOS:staging-nextfrom
wegank:sh-aarch64-darwin

Conversation

@wegank
Copy link
Member

@wegank wegank commented Nov 4, 2022 •
edited
Loading

Description of changes

Closes #199438.

Also, ZHF #199919

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 4, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 4, 2022
@wegank wegank force-pushed the sh-aarch64-darwin branch from 4896cd3 to 1a2d5e6 Compare November 4, 2022 02:32
@wegank wegank removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. labels Nov 4, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 4, 2022
@siriobalmelli
Copy link
Contributor

siriobalmelli commented Nov 4, 2022

Result of nixpkgs-review pr 199441 run on x86_64-darwin 1

@siriobalmelli
Copy link
Contributor

siriobalmelli commented Nov 4, 2022

LGTM

toonn
toonn reviewed Nov 5, 2022
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason disabledTests doesn't work?

@wegank
Copy link
Member Author

wegank commented Nov 5, 2022

@toonn The package uses unittest instead of pytest, so disabledTests won't work.

@wegank wegank requested a review from toonn November 5, 2022 20:59
@nixos-discourse
Copy link

nixos-discourse commented Nov 6, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1356

toonn
toonn approved these changes Nov 6, 2022
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. If unittest isn't compatible with disabledTests a patch seems like a good solution.

@mweinelt
Copy link
Member

mweinelt commented Nov 7, 2022

Pytest is compatible with unittest, so you can use pytestCheckHook instead with pytestFlagsArray = [ "test.py" ];. Then you can use disabledTests and purge the patch files.

@wegank wegank force-pushed the sh-aarch64-darwin branch from 1a2d5e6 to 9f6909e Compare November 7, 2022 06:30
@wegank
Copy link
Member Author

wegank commented Nov 7, 2022

@mweinelt Done. Although this will surely lead to massive rebuilds.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 7, 2022
@mweinelt
Copy link
Member

mweinelt commented Nov 7, 2022

Then please rebase onto staging-next for this one time. I'll set this PR to draft to prevent accidental review requests.

@mweinelt mweinelt marked this pull request as draft November 7, 2022 12:51
@wegank wegank force-pushed the sh-aarch64-darwin branch from 9f6909e to 370c1a9 Compare November 7, 2022 13:23
@wegank wegank changed the base branch from master to staging-next November 7, 2022 13:23
@wegank
Copy link
Member Author

wegank commented Nov 7, 2022

@mweinelt Rebased.

@mweinelt mweinelt marked this pull request as ready for review November 7, 2022 13:36
@mweinelt mweinelt merged commit 5134699 into NixOS:staging-next Nov 7, 2022
@wegank wegank deleted the sh-aarch64-darwin branch November 7, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toonn toonn toonn approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

python3Packages.sh fails to build on Hydra (aarch64-darwin)

5 participants

@wegank @siriobalmelli @nixos-discourse @mweinelt @toonn

Comments