Skip to content

haskellPackages.swarm: fix broken package#199356

Closed
natto1784 wants to merge 2 commits intoNixOS:masterfrom
natto1784:haskellPackages.swarm
Closed

haskellPackages.swarm: fix broken package#199356
natto1784 wants to merge 2 commits intoNixOS:masterfrom
natto1784:haskellPackages.swarm

Conversation

@natto1784
Copy link
Contributor

@natto1784 natto1784 commented Nov 3, 2022

Description of changes

Unbroke haskellPackages.swarm

Things done
  • Jailbroke haskellPackage.swarm
  • Added brick 1.0 because the jailbreaking did not help with it
  • Jailbroke brick 1.0 because it would not build
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Nov 3, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 3, 2022
sternenseemann
sternenseemann reviewed Nov 3, 2022
View reviewed changes
@natto1784
haskellPackages.brick: init brick-1.3 for swarm-0.1.1.0
dfce08b 
Signed-off-by: Amneesh Singh <natto@weirdnatto.in>
@natto1784
haskellPackages.swarm: fix broken package
c165bfa 
Signed-off-by: Amneesh Singh <natto@weirdnatto.in>
@natto1784 natto1784 force-pushed the haskellPackages.swarm branch from d8c4ef6 to c165bfa Compare November 5, 2022 06:05
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 5, 2022
@natto1784 natto1784 closed this Nov 13, 2022
@sternenseemann
Copy link
Member

sternenseemann commented Nov 13, 2022

Why did you close?

@natto1784
Copy link
Contributor Author

natto1784 commented Nov 15, 2022

Sorry about that. I assumed it was not really that important and since it had been a week and was clogging up the more important PRs upstream, I went ahead a closed it. Should I reopen?

@sternenseemann
Copy link
Member

sternenseemann commented Nov 15, 2022

Sure.

@natto1784 natto1784 mentioned this pull request Nov 15, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natto1784 @sternenseemann @maralorn