Skip to content

vscode-extensions.vscjava.vscode-gradle: init at 3.12.2022110200#199157

Merged
superherointj merged 1 commit intoNixOS:masterfrom
rhoriguchi:vscode-extensions.vscjava.vscode-gradle
Mar 23, 2023
Merged

vscode-extensions.vscjava.vscode-gradle: init at 3.12.2022110200#199157
superherointj merged 1 commit intoNixOS:masterfrom
rhoriguchi:vscode-extensions.vscjava.vscode-gradle

Conversation

@rhoriguchi
Copy link
Contributor

@rhoriguchi rhoriguchi commented Nov 2, 2022

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@rhoriguchi rhoriguchi requested a review from jonringer as a code owner November 2, 2022 12:54
@github-actions github-actions bot added the 6.topic: vscode A free and versatile code editor that supports almost every major programming language. label Nov 2, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 2, 2022
superherointj
superherointj reviewed Mar 9, 2023
View reviewed changes
superherointj
superherointj reviewed Mar 9, 2023
View reviewed changes
@superherointj superherointj added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 18, 2023
@rhoriguchi rhoriguchi force-pushed the vscode-extensions.vscjava.vscode-gradle branch from 6f54fb1 to cd4b4a6 Compare March 22, 2023 23:13
@rhoriguchi rhoriguchi removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 22, 2023
superherointj
superherointj reviewed Mar 22, 2023
View reviewed changes
superherointj
superherointj reviewed Mar 22, 2023
View reviewed changes
@superherointj
Copy link
Contributor

superherointj commented Mar 22, 2023 •
edited
Loading

Consider adding yourself as maintainer.

@rhoriguchi rhoriguchi force-pushed the vscode-extensions.vscjava.vscode-gradle branch from cd4b4a6 to 8795197 Compare March 23, 2023 19:12
@rhoriguchi
Copy link
Contributor Author

rhoriguchi commented Mar 23, 2023 •
edited
Loading

Consider adding yourself as maintainer.

I can add myself but I will probably not notice if it does not work, I use Gradle maybe once a year.

@rhoriguchi rhoriguchi force-pushed the vscode-extensions.vscjava.vscode-gradle branch from 8795197 to 65041d4 Compare March 23, 2023 19:15
@superherointj
Copy link
Contributor

superherointj commented Mar 23, 2023

Result of nixpkgs-review pr 199157 run on x86_64-linux 1

1 package built:
  • vscode-extensions.vscjava.vscode-gradle

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Mar 23, 2023
@superherointj superherointj merged commit 70a5ffc into NixOS:master Mar 23, 2023
@rhoriguchi rhoriguchi deleted the vscode-extensions.vscjava.vscode-gradle branch March 23, 2023 23:31
@ShamrockLee ShamrockLee mentioned this pull request Mar 25, 2023
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShamrockLee ShamrockLee ShamrockLee left review comments

@jonringer jonringer Awaiting requested review from jonringer

+1 more reviewer

@superherointj superherointj superherointj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhoriguchi @superherointj @ShamrockLee