Skip to content

numpy: enable numpy.distutils patch only if it's also in distutils#19907

Merged
FRidh merged 1 commit intoNixOS:masterfrom
veprbl:distutils_fix2
Oct 27, 2016
Merged

numpy: enable numpy.distutils patch only if it's also in distutils#19907
FRidh merged 1 commit intoNixOS:masterfrom
veprbl:distutils_fix2

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Oct 26, 2016

Motivation for this change

Fix a bug in #19585

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fixes: 095095c ('python: add C++ compiler support for distutils')
Cc: @FRidh

Fixes: 095095c ('python: add C++ compiler support for distutils')
@mention-bot
Copy link

@veprbl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @edolstra and @chaoflow to be potential reviewers.

@FRidh FRidh self-assigned this Oct 27, 2016
@FRidh
Copy link
Member

FRidh commented Oct 27, 2016

testing now

@FRidh FRidh added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 27, 2016
@FRidh FRidh merged commit 600f4dd into NixOS:master Oct 27, 2016
@veprbl veprbl deleted the distutils_fix2 branch December 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants