buf: remove reliance of tests on git file transport#199015
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Nov 7, 2022
Merged
buf: remove reliance of tests on git file transport#199015SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
Member
|
If this is just a test failure due to a change in Git's behaviour can we just delete |
Member
Author
|
I think it's easier to patch which can be dropped with the next buf release easily as it's already upstream. I can filter the ci file out in the patch, but it's also not like it really matters… |
A recent git security update disabled the file transport by default, see https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253 We can pick an upstream patch which needed to be rebased unfortunately, so we can't fetch it directly from GitHub.
1d2ba52 to
ebb0a9b
Compare
Member
Author
|
Dropped the ci config file from the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent git security update disabled the file transport by default, see https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253
We can pick an upstream patch which needed to be rebased unfortunately, so we can't fetch it directly from GitHub.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes