jekyll-favicon: Add to full Jekyll setup #198601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: kernel
6.topic: nixos
6.topic: printing
6.topic: python
6.topic: ruby
6.topic: rust
6.topic: systemd
6.topic: TeX
github-actions
bot
removed
6.topic: systemd
6.topic: TeX
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
l0b0
force-pushed
the
feat/add-jekyll-favicon-to-full-jekyll-setup
branch
from
c917e09
to
10fcf47
Compare
l0b0
force-pushed
the
feat/add-jekyll-favicon-to-full-jekyll-setup
branch
from
10fcf47
to
f4c278c
Compare
|
Result of 2 packages built:
|
raboof
approved these changes
Nov 28, 2022
| @@ -101,4 +101,4 @@ DEPENDENCIES | |||
| jemoji | |||
|
|
|||
| BUNDLED WITH | |||
| 2.3.25 | |||
| 2.3.9 | |||
There was a problem hiding this comment.
We should just remove the bundled with section TBH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Include jekyll-favicon when
withOptionalDependenciesis set.At-ing other gemset.nix contributors @primeos @raboof @grahamc @anthonyroussel since there's no official maintainer.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes