Skip to content

file: fix doCheck conditional for pkgsMusl.pkgsCross.gnu64#198409

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
yu-re-ka:file-check-musl
Oct 29, 2022
Merged

file: fix doCheck conditional for pkgsMusl.pkgsCross.gnu64#198409
doronbehar merged 1 commit intoNixOS:masterfrom
yu-re-ka:file-check-musl

Conversation

@yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Oct 29, 2022

Description of changes

The tests can actually run and succeed on pkgsCross.mus64.file, but instead the failure also happens on pkgsMusl.pkgsCross.gnu64.file, so the conditional needs to changed.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@yu-re-ka yu-re-ka mentioned this pull request Oct 29, 2022
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 29, 2022
@doronbehar doronbehar merged commit 42cc8b6 into NixOS:master Oct 29, 2022
@yu-re-ka yu-re-ka deleted the file-check-musl branch November 3, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants