Skip to content

cargo-llvm-cov: init at 0.5.0#197453

Closed
CobaltCause wants to merge 2 commits intoNixOS:masterfrom
CobaltCause:add-cargo-llvm-cov
Closed

cargo-llvm-cov: init at 0.5.0#197453
CobaltCause wants to merge 2 commits intoNixOS:masterfrom
CobaltCause:add-cargo-llvm-cov

Conversation

@CobaltCause
Copy link
Contributor

Description of changes

This packages cargo-llvm-cov, a tool for generating code coverage reports using built-in features of recent Rust toolchains.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 24, 2022
@winterqt
Copy link
Member

winterqt commented Oct 24, 2022

Thanks for the PR, but this is a dupe of #185183.

I'd appreciate it if you could go over that PR if you have any suggestions or comments, plus test it, if you'd like :)

Thanks again, and I hope you contribute more to Nixpkgs in the future!

@winterqt winterqt closed this Oct 24, 2022
@CobaltCause
Copy link
Contributor Author

Oh lol I should've checked for that. They also appear to have gotten the tests working while I just ignored them, which is definitely better. Thanks!

@winterqt
Copy link
Member

winterqt commented Oct 24, 2022

They also appear to have gotten the tests working while I just ignored them

I just used a less verbose method of disabling just those broken tests there, they're still broken since we don't ship llvm-tools-preview.

@CobaltCause
Copy link
Contributor Author

If you re-open this PR, I actually just reworked it in a way where all the tests run and pass properly: CobaltCause@1415724

@CobaltCause
Copy link
Contributor Author

Note: refactoring this to use fetchCrate instead of fetchFromGithub causes the tests to stop working.

@winterqt
Copy link
Member

Yes, this is because Cargo skips the fixture directories when packing for publishing, since it thinks they're unrelated crates.

I'd love to reopen this, but...
image

@CobaltCause
Copy link
Contributor Author

Oh, yeah I did force-push to fix the tests. Should I re-open as a new PR?

@winterqt
Copy link
Member

winterqt commented Oct 24, 2022

Go for it -- there's one change I want to try to not have to add the Cargo.lock, but other than that it should be good to go :)

@CobaltCause
Copy link
Contributor Author

Done: #197478

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants