Conversation
df87361 to
fcaed8b
Compare
fcaed8b to
fc763f8
Compare
|
Thanks for the PR, but this is a dupe of #185183. I'd appreciate it if you could go over that PR if you have any suggestions or comments, plus test it, if you'd like :) Thanks again, and I hope you contribute more to Nixpkgs in the future! |
|
Oh lol I should've checked for that. They also appear to have gotten the tests working while I just ignored them, which is definitely better. Thanks! |
I just used a less verbose method of disabling just those broken tests there, they're still broken since we don't ship llvm-tools-preview. |
|
If you re-open this PR, I actually just reworked it in a way where all the tests run and pass properly: CobaltCause@1415724 |
|
Note: refactoring this to use |
|
Oh, yeah I did force-push to fix the tests. Should I re-open as a new PR? |
|
Go for it -- there's one change I want to try to not have to add the Cargo.lock, but other than that it should be good to go :) |
|
Done: #197478 |

Description of changes
This packages cargo-llvm-cov, a tool for generating code coverage reports using built-in features of recent Rust toolchains.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes