Skip to content

Conversation

@YorikSar
Copy link
Contributor

Description of changes

Several instances of this test fail with error like:

AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods should not have native support on Darwin while modern systems have such support.

This gates building of a bunch of Python packages on Darwin, including Ansible.

Found while looking through errors for staging-next PR #195862

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have native support on Darwin while modern systems have such
support.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 21, 2022
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 21, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 21, 2022
@YorikSar
Copy link
Contributor Author

Note that this package was broken, so "101-500" rebuilds are actually potentially new working packages.

@YorikSar
Copy link
Contributor Author

Result of nixpkgs-review pr 197077 run on aarch64-darwin 1

46 packages marked as broken and skipped:
  • baserow
  • buildbot
  • buildbot-full
  • buildbot-ui
  • dyndnsc
  • etesync-dav
  • grab-site
  • magic-wormhole
  • mailman
  • mailman-hyperkitty
  • mitmproxy
  • mitmproxy2swagger
  • odoo
  • paperless-ngx
  • privacyidea
  • python310Packages.buildbot
  • python310Packages.buildbot-full
  • python310Packages.buildbot-ui
  • python310Packages.channels
  • python310Packages.channels-redis
  • python310Packages.daphne
  • python310Packages.json-logging
  • python310Packages.ldaptor
  • python310Packages.magic-wormhole
  • python310Packages.magic-wormhole-mailbox-server
  • python310Packages.mitmproxy
  • python310Packages.privacyidea-ldap-proxy
  • python310Packages.pytest-ansible
  • python310Packages.strawberry-graphql
  • python39Packages.buildbot
  • python39Packages.buildbot-full
  • python39Packages.buildbot-ui
  • python39Packages.channels
  • python39Packages.channels-redis
  • python39Packages.daphne
  • python39Packages.json-logging
  • python39Packages.ldaptor
  • python39Packages.magic-wormhole
  • python39Packages.magic-wormhole-mailbox-server
  • python39Packages.mitmproxy
  • python39Packages.privacyidea-ldap-proxy
  • python39Packages.pytest-ansible
  • python39Packages.strawberry-graphql
  • wapiti
  • zeroc-ice
  • zeroc-ice-cpp11
65 packages failed to build:
  • ansible (ansible_2_12)
  • ansible-later (python310Packages.ansible-later)
  • ansible-lint (python310Packages.ansible-lint)
  • ansible_2_13 (python310Packages.ansible-core)
  • buildbot-worker (python310Packages.buildbot-worker)
  • datadog-agent
  • datadog-process-agent
  • napalm
  • parsedmarc (python310Packages.parsedmarc)
  • pypiserver (python310Packages.pypiserver)
  • python310Packages.aiofile
  • python310Packages.aiomisc
  • python310Packages.amqtt
  • python310Packages.ansible
  • python310Packages.ansible-compat
  • python310Packages.ansible-kernel
  • python310Packages.ansible-runner
  • python310Packages.bimmer-connected
  • python310Packages.caio
  • python310Packages.geoip2
  • python310Packages.magic-wormhole-transit-relay
  • python310Packages.mocket
  • python310Packages.napalm
  • python310Packages.napalm-hp-procurve
  • python310Packages.radicale_infcloud
  • python310Packages.roombapy
  • python310Packages.sopel
  • ttp (python310Packages.ttp)
  • python310Packages.volvooncall
  • python39Packages.aiofile
  • python39Packages.aiomisc
  • python39Packages.amqtt
  • python39Packages.ansible
  • python39Packages.ansible-compat
  • python39Packages.ansible-core
  • python39Packages.ansible-kernel
  • python39Packages.ansible-later
  • python39Packages.ansible-lint
  • python39Packages.ansible-runner
  • python39Packages.bimmer-connected
  • python39Packages.buildbot-worker
  • python39Packages.caio
  • python39Packages.geoip2
  • python39Packages.magic-wormhole-transit-relay
  • python39Packages.mocket
  • python39Packages.napalm
  • python39Packages.napalm-hp-procurve
  • python39Packages.parsedmarc
  • python39Packages.pypiserver
  • python39Packages.radicale_infcloud
  • python39Packages.roombapy
  • python39Packages.sopel
  • python39Packages.ttp
  • python39Packages.volvooncall
  • radicale (radicale3)
  • sourcehut.buildsrht
  • sourcehut.dispatchsrht
  • sourcehut.gitsrht
  • sourcehut.hgsrht
  • sourcehut.hubsrht
  • sourcehut.listssrht
  • sourcehut.mansrht
  • sourcehut.metasrht
  • sourcehut.pastesrht
  • sourcehut.todosrht
47 packages built:
  • apache-airflow (python310Packages.apache-airflow)
  • devpi-client
  • devpi-server
  • etebase-server (python310Packages.etebase-server)
  • gam
  • octoprint
  • pgadmin4
  • python310Packages.autobahn
  • python310Packages.ciscoconfparse
  • python310Packages.dependency-injector
  • python310Packages.fastapi
  • python310Packages.fastapi-mail
  • python310Packages.flask-admin
  • python310Packages.flask-appbuilder
  • python310Packages.flask-security-too
  • python310Packages.ihatemoney
  • python310Packages.ormar
  • python310Packages.passlib
  • python310Packages.pg8000
  • python310Packages.slowapi
  • python310Packages.sqlalchemy-continuum
  • python310Packages.sqlalchemy-i18n
  • python310Packages.sqlalchemy-utils
  • trytond (python310Packages.trytond)
  • python39Packages.apache-airflow
  • python39Packages.autobahn
  • python39Packages.ciscoconfparse
  • python39Packages.dependency-injector
  • python39Packages.etebase-server
  • python39Packages.fastapi
  • python39Packages.fastapi-mail
  • python39Packages.flask-admin
  • python39Packages.flask-appbuilder
  • python39Packages.flask-security-too
  • python39Packages.ihatemoney
  • python39Packages.ormar
  • python39Packages.passlib
  • python39Packages.pg8000
  • python39Packages.slowapi
  • python39Packages.sqlalchemy-continuum
  • python39Packages.sqlalchemy-i18n
  • python39Packages.sqlalchemy-utils
  • python39Packages.trytond
  • radicale2
  • soco-cli
  • sourcehut.coresrht
  • theharvester

1 similar comment
@YorikSar
Copy link
Contributor Author

Result of nixpkgs-review pr 197077 run on aarch64-darwin 1

46 packages marked as broken and skipped:
  • baserow
  • buildbot
  • buildbot-full
  • buildbot-ui
  • dyndnsc
  • etesync-dav
  • grab-site
  • magic-wormhole
  • mailman
  • mailman-hyperkitty
  • mitmproxy
  • mitmproxy2swagger
  • odoo
  • paperless-ngx
  • privacyidea
  • python310Packages.buildbot
  • python310Packages.buildbot-full
  • python310Packages.buildbot-ui
  • python310Packages.channels
  • python310Packages.channels-redis
  • python310Packages.daphne
  • python310Packages.json-logging
  • python310Packages.ldaptor
  • python310Packages.magic-wormhole
  • python310Packages.magic-wormhole-mailbox-server
  • python310Packages.mitmproxy
  • python310Packages.privacyidea-ldap-proxy
  • python310Packages.pytest-ansible
  • python310Packages.strawberry-graphql
  • python39Packages.buildbot
  • python39Packages.buildbot-full
  • python39Packages.buildbot-ui
  • python39Packages.channels
  • python39Packages.channels-redis
  • python39Packages.daphne
  • python39Packages.json-logging
  • python39Packages.ldaptor
  • python39Packages.magic-wormhole
  • python39Packages.magic-wormhole-mailbox-server
  • python39Packages.mitmproxy
  • python39Packages.privacyidea-ldap-proxy
  • python39Packages.pytest-ansible
  • python39Packages.strawberry-graphql
  • wapiti
  • zeroc-ice
  • zeroc-ice-cpp11
65 packages failed to build:
  • ansible (ansible_2_12)
  • ansible-later (python310Packages.ansible-later)
  • ansible-lint (python310Packages.ansible-lint)
  • ansible_2_13 (python310Packages.ansible-core)
  • buildbot-worker (python310Packages.buildbot-worker)
  • datadog-agent
  • datadog-process-agent
  • napalm
  • parsedmarc (python310Packages.parsedmarc)
  • pypiserver (python310Packages.pypiserver)
  • python310Packages.aiofile
  • python310Packages.aiomisc
  • python310Packages.amqtt
  • python310Packages.ansible
  • python310Packages.ansible-compat
  • python310Packages.ansible-kernel
  • python310Packages.ansible-runner
  • python310Packages.bimmer-connected
  • python310Packages.caio
  • python310Packages.geoip2
  • python310Packages.magic-wormhole-transit-relay
  • python310Packages.mocket
  • python310Packages.napalm
  • python310Packages.napalm-hp-procurve
  • python310Packages.radicale_infcloud
  • python310Packages.roombapy
  • python310Packages.sopel
  • ttp (python310Packages.ttp)
  • python310Packages.volvooncall
  • python39Packages.aiofile
  • python39Packages.aiomisc
  • python39Packages.amqtt
  • python39Packages.ansible
  • python39Packages.ansible-compat
  • python39Packages.ansible-core
  • python39Packages.ansible-kernel
  • python39Packages.ansible-later
  • python39Packages.ansible-lint
  • python39Packages.ansible-runner
  • python39Packages.bimmer-connected
  • python39Packages.buildbot-worker
  • python39Packages.caio
  • python39Packages.geoip2
  • python39Packages.magic-wormhole-transit-relay
  • python39Packages.mocket
  • python39Packages.napalm
  • python39Packages.napalm-hp-procurve
  • python39Packages.parsedmarc
  • python39Packages.pypiserver
  • python39Packages.radicale_infcloud
  • python39Packages.roombapy
  • python39Packages.sopel
  • python39Packages.ttp
  • python39Packages.volvooncall
  • radicale (radicale3)
  • sourcehut.buildsrht
  • sourcehut.dispatchsrht
  • sourcehut.gitsrht
  • sourcehut.hgsrht
  • sourcehut.hubsrht
  • sourcehut.listssrht
  • sourcehut.mansrht
  • sourcehut.metasrht
  • sourcehut.pastesrht
  • sourcehut.todosrht
47 packages built:
  • apache-airflow (python310Packages.apache-airflow)
  • devpi-client
  • devpi-server
  • etebase-server (python310Packages.etebase-server)
  • gam
  • octoprint
  • pgadmin4
  • python310Packages.autobahn
  • python310Packages.ciscoconfparse
  • python310Packages.dependency-injector
  • python310Packages.fastapi
  • python310Packages.fastapi-mail
  • python310Packages.flask-admin
  • python310Packages.flask-appbuilder
  • python310Packages.flask-security-too
  • python310Packages.ihatemoney
  • python310Packages.ormar
  • python310Packages.passlib
  • python310Packages.pg8000
  • python310Packages.slowapi
  • python310Packages.sqlalchemy-continuum
  • python310Packages.sqlalchemy-i18n
  • python310Packages.sqlalchemy-utils
  • trytond (python310Packages.trytond)
  • python39Packages.apache-airflow
  • python39Packages.autobahn
  • python39Packages.ciscoconfparse
  • python39Packages.dependency-injector
  • python39Packages.etebase-server
  • python39Packages.fastapi
  • python39Packages.fastapi-mail
  • python39Packages.flask-admin
  • python39Packages.flask-appbuilder
  • python39Packages.flask-security-too
  • python39Packages.ihatemoney
  • python39Packages.ormar
  • python39Packages.passlib
  • python39Packages.pg8000
  • python39Packages.slowapi
  • python39Packages.sqlalchemy-continuum
  • python39Packages.sqlalchemy-i18n
  • python39Packages.sqlalchemy-utils
  • python39Packages.trytond
  • radicale2
  • soco-cli
  • sourcehut.coresrht
  • theharvester

@vcunat
Copy link
Member

vcunat commented Oct 21, 2022

Typical modern systems don't have the support, I think. At least I expect our libxcrypt on darwin is currently a little unusual (but sounds fine for improved cross-platform consistency). #181764 (comment)

@vcunat vcunat merged commit a2d5dc2 into NixOS:master Oct 22, 2022
@YorikSar YorikSar deleted the passlib-darwin-tests-skip branch October 22, 2022 15:05
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jun 19, 2023
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jul 14, 2023
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jul 21, 2023
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Aug 7, 2023
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Sep 7, 2023
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Oct 20, 2023
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Dec 14, 2023
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Dec 22, 2023
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jan 13, 2024
…197077)

Several instances of this test fail with error like:

  AssertionError: did not expect 'darwin' platform would have native support for '...'

It looks like passlib's tests erroneously assume that some methods
should not have support on Darwin while current nixpkgs does
support it through libxcrypt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants