Skip to content

Unbreak haskellPackages: vado, uuid-bytes, scotty-form, data-compat, copilot-c99, binsm#196767

Merged
cdepillabout merged 6 commits intoNixOS:haskell-updatesfrom
markus1189:haskellPackages-unbreak
Oct 19, 2022
Merged

Unbreak haskellPackages: vado, uuid-bytes, scotty-form, data-compat, copilot-c99, binsm#196767
cdepillabout merged 6 commits intoNixOS:haskell-updatesfrom
markus1189:haskellPackages-unbreak

Conversation

@markus1189
Copy link
Contributor

Description of changes

Had some spare CPU time and fount more haskellPackages that build: vado, uuid-bytes, scotty-form, data-compat, copilot-c99, binsm

I hope that the commit message is enough to trigger correct OfBorg evaluation? Or would it be preferred to open separate PRs for every package?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Oct 19, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 19, 2022
@cdepillabout
Copy link
Member

Great, thanks a lot! We really appreciate it!

I hope that the commit message is enough to trigger correct OfBorg evaluation? Or would it be preferred to open separate PRs for every package?

It looks like ofborg picked this up! Doing this in one PR is completely fine, especially since it is just unbreaking packages.

@cdepillabout cdepillabout merged commit 9fce308 into NixOS:haskell-updates Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants