Skip to content

starship: reenable default features on darwin#195604

Merged
marsam merged 1 commit intoNixOS:masterfrom
tjni:starship
Nov 5, 2022
Merged

starship: reenable default features on darwin#195604
marsam merged 1 commit intoNixOS:masterfrom
tjni:starship

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Oct 12, 2022

Description of changes

Since #191235 is in master, we can rebuild starship on aarch64-darwin again with all of its features.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 12, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 12, 2022
@tjni tjni marked this pull request as draft October 12, 2022 06:03
@tjni
Copy link
Contributor Author

tjni commented Oct 12, 2022

Converting into a draft because x86 darwin is broken and need to investigate why.

@tjni tjni marked this pull request as ready for review November 5, 2022 03:30
@marsam marsam merged commit a395a15 into NixOS:master Nov 5, 2022
@tjni tjni deleted the starship branch November 5, 2022 06:24
@szlend szlend mentioned this pull request Nov 24, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danth danth Awaiting requested review from danth

@Frostman Frostman Awaiting requested review from Frostman

@davidtwco davidtwco Awaiting requested review from davidtwco

@marsam marsam Awaiting requested review from marsam

@bbigras bbigras Awaiting requested review from bbigras

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjni @marsam