Skip to content

haskellPackages.snaplet-purescript: GHC9 compatibility#195224

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
dalpd:fix-snaplet-purescript
Oct 9, 2022
Merged

haskellPackages.snaplet-purescript: GHC9 compatibility#195224
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
dalpd:fix-snaplet-purescript

Conversation

@dalpd
Copy link
Contributor

@dalpd dalpd commented Oct 9, 2022

Description of changes

Simplified subsumption breaking the build of snaplet-purescript.

Things done

Stop eta reducing while using the function broken.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Oct 9, 2022
@dalpd dalpd force-pushed the fix-snaplet-purescript branch from 49fab76 to 903b575 Compare October 9, 2022 11:51
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 9, 2022
@cdepillabout
Copy link
Member

cdepillabout commented Oct 9, 2022

Thanks again, looks good!

@cdepillabout cdepillabout merged commit 0f955bb into NixOS:haskell-updates Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dalpd @cdepillabout