poetry2nix: 1.31.0 -> 1.33.0 #194865
Merged
poetry2nix: 1.31.0 -> 1.33.0 #194865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
poetry2nix-1_32_1
branch
from
1fc1639 to
5d73a5b
Compare
adisbladis
force-pushed
the
poetry2nix-1_32_1
branch
from
5d73a5b to
f439af5
Compare
ofborg
bot
requested review from
AmineChikhaoui,
domenkozar,
edolstra,
jbaum98 and
rbvermaa
ofborg
bot
added
11.by: package-maintainer
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
Why is the poetry2nix directory duplicated?
Comment on lines
+68
to
+71
| # Override buggy nixpkgs function | ||
| pythonOutputDistPhase() { | ||
| echo "no-op output dist phase" | ||
| } |
Member
There was a problem hiding this comment.
What is wrong with the dist phase? Can we try to fix it, please.
| { | ||
| # "Vendor" dependencies (for build-system support) | ||
| postPatch = '' | ||
| find . |
Member
There was a problem hiding this comment.
Suggested change
| find . |
That command just lists all files which spams the build log.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes the fallout from the recent python setuptools staging changes and bumps the poetry version to 1.2.1.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes