p11-kit: add darwin tls ca store path#194844
Merged
rnhmjoj merged 1 commit intoNixOS:stagingfrom Oct 12, 2022
Merged
Conversation
13 tasks
rnhmjoj
approved these changes
Oct 7, 2022
Member
Author
|
@rnhmjoj, any chance this could be merged before the next staging cycle starts or do you want someone else to give it an additional review first? |
Contributor
|
I was giving some time for others to review, but it been a while and this change should be completely harmless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Allows p11-kit to correctly find the root CA store on macOS. This is relevant when building something like curl with NSS and are intending to use libnssckbi (p11-trust-kit) for the CA store (like the
curl-impersonate-ffderivation from #194310)I tested this in GitHub Actions (since I don't have a Mac) and this patch allowed
curl-impersonate-ffto work correctlyThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes