Conversation
|
@vbgl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bzizou, @lethalman and @MarcWeber to be potential reviewers. |
| , netcdfSupport ? true | ||
| }: | ||
| , pythonSupport ? !stdenv.isDarwin | ||
| }: |
There was a problem hiding this comment.
Could you change this to true and pass pythonSupport = !stdenv.isDarwin; in all-packages.nix. In python-packages.nix we override gdal to use the version of the Python interpreter that specific set is build for. Those builds should fail and not silently build without Python.
There was a problem hiding this comment.
actually, that won't make a difference, because we override the call. You can ignore my previous comment. :-)
| "--with-mysql=${mysql.lib.dev}/bin/mysql_config" | ||
| "--with-geotiff=${libgeotiff}" | ||
| "--with-python" # optional | ||
| "--with-python${if pythonSupport then "" else "=no"}" |
There was a problem hiding this comment.
perhaps be explicit and add yes ?
|
reference to issue #18194 |
|
There might be a better way to solve this issue than to disable python altogether. Edit: |
|
This has been fixed in 468a5bc. |
4 participants
Motivation for this change
Enabling python support on darwin results in a build failure.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)