arangodb: 3.4.8 -> 3.10.0 by jsoo1 · Pull Request #194670 · NixOS/nixpkgs

jsoo1 · 2022-10-05T23:46:35Z

Description of changes

arangodb was out of date (last commited 2018). This brings it to a more current version.

Things done

jsoo1 · 2022-10-06T00:56:02Z

Turns out 3.9.3 -> 3.10.0 wasn't too bad.

nixos/doc/manual/release-notes/rl-2211.section.md

pkgs/servers/nosql/arangodb/default.nix

yorickvP · 2022-10-10T07:04:25Z

jsoo1 · 2022-10-10T13:48:39Z

Vulnerability roundup 103: arangodb-3.5.1: 1 advisory [6.1] #128338

Vulnerability roundup 103: arangodb-3.4.8: 1 advisory [6.1] #128337

Vulnerability roundup 103: arangodb-3.3.24: 1 advisory [6.1] #128336

Is 3.10.0 still effected? If so, I suppose we could mark it insecure.

risicle · 2022-10-10T22:16:32Z

Very unlikely, I think @yorickvP 's point is this will fix those issues.

yorickvP · 2022-10-12T07:24:35Z

Yep, this upgrade will fix those issues.

jsoo1 · 2022-10-12T20:46:02Z

Yep, this upgrade will fix those issues.

I see, thanks for the clarification!

vcunat · 2022-10-25T18:27:18Z

That reasoning doesn't make sense to me. You'd get gcc11 (which is supported by upstream). Instead you force gcc10, with an argument speaking against such a change.

vcunat · 2022-10-25T19:41:17Z

It (now) doesn't build for me on x86_64 NixOS. Maybe there was some (other) reason to downgrade compiler version. The errors look like changes around standard strictness, etc. (complex C++ traces; probably no sense to post them here)

jsoo1 · 2022-10-25T19:58:51Z

It (now) doesn't build for me on x86_64 NixOS. Maybe there was some (other) reason to downgrade compiler version. The errors look like changes around standard strictness, etc. (complex C++ traces; probably no sense to post them here)

Same. I will investigate.

jsoo1 · 2022-10-27T00:33:31Z

I found a new problem - maybe or maybe not related to compile failures - /proc/cpuinfo is read unconditionally for architecture feature detection. You turn this off by specifying -DTARGET_ARCHITECTURE=xyz up front. However, -DTARGET_ARCHITECTURE=generic seems like the best choice and that causes the vendored v8 not to compile.

edit: see arangodb/arangodb@cc860c3

3.{3,4,5} all reached EOL

It is unused.

It fails to apply

Which were EOL long ago.

Co-authored-by: Robert Scott <code@humanleg.org.uk>

USE_OPTIMIZE_FOR_ARCHITECTURE was removed without commit in a prior commit. This is because it was removed upstream: arangodb/arangodb@cc860c3 This is unfortunate - now /proc/cpuinfo is read unconditionally for feature detection. Some other means of feature detection will have to be found.

It seems that gcc11 - though reportedly supported - introduced some constraint that arangodb fails to compile with.

From https://www.arangodb.com/docs/stable/installation-compiling-debian.html

Avoid non-deterministic builds of ArangoDB proper. Note that this provides 0 guarantees about the vendored libraries doing anything similar.

If -DTARGET_ARCHITECTURE is supplied arango's cmake configuration will not use /proc/cpuinfo for feature detection. However, `generic` and `none` options both fail when building the vendored v8. This workaround provides some defaults, but warns if no override is provided.

As far as I can tell, this can cause compile failures when building the vendored abseil_cpp if choosing a target arch that does not support sse. This might be possible to determine programmatically, but it is more flexible to let the user decide.

For which no reliable default target architecture is provided upstream.

jsoo1 · 2022-10-31T16:57:36Z

I decided to keep only x86_64-linux as the supported system for arangodb since I can't find a reasonable default value for -DTARGET_ARCHITECTURE on aarch64-linux. I documented the change and how to alter the new parameters.

Also, I used haswell as the default architecture since generic and none both fail to build and I don't really have the time to understand why. I documented this change and how to alter that behavior as well.

jsoo1 · 2022-10-31T17:12:21Z

This is probably about as much effort as I can give to this package at the moment. Hopefully what I have is sufficient but I would be happy to see some other eyes on this.

nixos-discourse · 2022-11-07T20:23:36Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1378

SuperSandro2000 · 2022-11-08T11:36:26Z

pkgs/servers/nosql/arangodb/default.nix

+    description = "A native multi-model database with flexible data models for documents, graphs, and key-values";
+    license = licenses.asl20;
+    platforms = [ "x86_64-linux" ];
+    maintainers = [ maintainers.flosse maintainers.jsoo1 ];


Suggested change

maintainers = [ maintainers.flosse maintainers.jsoo1 ];

maintainers = with maintainers; [ flosse jsoo1 ];

SuperSandro2000 · 2022-11-08T11:37:09Z

pkgs/servers/nosql/arangodb/default.nix

+  # prevent failing with "cmake-3.13.4/nix-support/setup-hook: line 10: ./3rdParty/rocksdb/RocksDBConfig.cmake.in: No such file or directory"
+  dontFixCmake = true;
+  NIX_CFLAGS_COMPILE = "-Wno-error";
+  preConfigure = "patchShebangs utils";


This should really be a multiline string.

Thank you! #200210

ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch 8.has: clean-up This PR removes packages or removes other cruft and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 5, 2022

ofborg bot requested a review from flosse October 6, 2022 00:08

jsoo1 changed the title ~~arangodb: 3.4.8 -> 3.9.3~~ arangodb: 3.4.8 -> 3.10.0 Oct 6, 2022

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Oct 6, 2022

ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Oct 6, 2022

jsoo1 mentioned this pull request Oct 6, 2022

python3Packages.python-arango: init at 7.5.1 #193783

Merged

13 tasks

risicle reviewed Oct 8, 2022

View reviewed changes

nixos/doc/manual/release-notes/rl-2211.section.md Outdated Show resolved Hide resolved

risicle reviewed Oct 8, 2022

View reviewed changes

pkgs/servers/nosql/arangodb/default.nix Show resolved Hide resolved

yorickvP added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 10, 2022

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 25, 2022

jsoo1 mentioned this pull request Oct 27, 2022

Nix - Compile errors with gcc 11.3.0 arangodb/arangodb#17454

Closed

arangodb_3_9: init at 3.9.3

6be6c33

jsoo1 and others added 19 commits October 30, 2022 10:20

arangodb_3_x: remove unsupported versions

45dd4a1

3.{3,4,5} all reached EOL

arangodb: use gcc 10 (supported version)

e1df4f5

arangodb: remove enableParallelBuilding

0da384e

It is unused.

arangodb: drop boost patch

a6ffb2d

It fails to apply

arangodb: 3.9.3 -> 3.10.0

6c75f96

arangodb: note removal of old versions in rl-2211 notes

86e1247

arangodb: disable "maintainer mode"

c3bfecd

aliases.nix: add throws for arangodb_3_{3,4,5}

cd06546

Which were EOL long ago.

arangodb: annotate gcc10Stdenv reasoning

9f1e7c2

Co-authored-by: Robert Scott <code@humanleg.org.uk>

arangodb: stdenvGcc10->stdenv since gcc 11+ is suggested

704d2dc

arangodb: stdenv->gcc10Stdenv to compile

56eecda

It seems that gcc11 - though reportedly supported - introduced some constraint that arangodb fails to compile with.

arangodb: additional cmake flags for releases

2f6e24b

From https://www.arangodb.com/docs/stable/installation-compiling-debian.html

arangodb: avoid reading /proc/cpuinfo during build

10fda11

Avoid non-deterministic builds of ArangoDB proper. Note that this provides 0 guarantees about the vendored libraries doing anything similar.

arangodb: capitalize cmake flag

6cb592a

arangodb: annotate reasoning for gcc 11->10 downgrade

1e17110

arangodb: no warning when defaulting target arch

f5bab1e

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 30, 2022

jsoo1 added 2 commits October 31, 2022 09:44

arangodb: remove aarch64 support

8e36431

For which no reliable default target architecture is provided upstream.

arangodb: document new parameters and aarch64-linux drop

f258503

vcunat merged commit 7fa607b into NixOS:master Nov 7, 2022

SuperSandro2000 reviewed Nov 8, 2022

View reviewed changes

LeSuisse mentioned this pull request Nov 12, 2022

arangodb_3_3: drop, arangodb_3_4, arangodb_3_5: mark vulnerable to CVE-2021-25938 #198549

Closed

13 tasks

jsoo1 deleted the jsoo1/arangodb-bump branch December 6, 2022 15:07

	maintainers = [ maintainers.flosse maintainers.jsoo1 ];
	maintainers = with maintainers; [ flosse jsoo1 ];

Uh oh!

Conversation

jsoo1 commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

jsoo1 commented Oct 6, 2022

Uh oh!

Uh oh!

Uh oh!

yorickvP commented Oct 10, 2022

Uh oh!

jsoo1 commented Oct 10, 2022

Uh oh!

risicle commented Oct 10, 2022

Uh oh!

yorickvP commented Oct 12, 2022

Uh oh!

jsoo1 commented Oct 12, 2022

Uh oh!

vcunat commented Oct 25, 2022

Uh oh!

vcunat commented Oct 25, 2022

Uh oh!

jsoo1 commented Oct 25, 2022

Uh oh!

jsoo1 commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsoo1 commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsoo1 commented Oct 31, 2022

Uh oh!

nixos-discourse commented Nov 7, 2022

Uh oh!

SuperSandro2000 Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

jsoo1 Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jsoo1 commented Oct 5, 2022 •

edited

Loading

jsoo1 commented Oct 27, 2022 •

edited

Loading

jsoo1 commented Oct 31, 2022 •

edited

Loading