Skip to content

Comments

lib.nixos.runTest: Return the test itself#193361

Merged
roberth merged 1 commit intoNixOS:masterfrom
hercules-ci:nixos-lib-runTest-return-test
Sep 28, 2022
Merged

lib.nixos.runTest: Return the test itself#193361
roberth merged 1 commit intoNixOS:masterfrom
hercules-ci:nixos-lib-runTest-return-test

Conversation

@roberth
Copy link
Member

@roberth roberth commented Sep 28, 2022 •
edited
Loading

Description of changes

(NB: the lib in the flake)

Correcting a mistake I made when removing the test matrix code from #191540

Doc: https://github.com/NixOS/nixpkgs/pull/191540/files#diff-53201fd9a776413fa35cb167cab111999bafe5580f579c80eaa850678a7b4599R70-R83

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@roberth
lib.nixos.runTest: Return the test itself
12b3066 
(NB: the lib in the flake)

Correcting a mistake I made when removing the test matrix code
from NixOS#191540
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Sep 28, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 28, 2022
@roberth roberth merged commit 52392d4 into NixOS:master Sep 28, 2022
@vcunat
Copy link
Member

vcunat commented Sep 29, 2022

@roberth: many tests won't evaluate, blocking evaluation of unstable-small. I bisected to this commit. Simple test:

$ nix build -f nixos/release-small.nix nixos.tests.proxy.x86_64-linux --dry-run
error: attribute 'x86_64-linux' in selection path 'nixos.tests.proxy.x86_64-linux' not found

@roberth
Copy link
Member Author

roberth commented Sep 29, 2022

On it.

@roberth
Copy link
Member Author

roberth commented Sep 29, 2022

Fix in #193485

@roberth
Copy link
Member Author

roberth commented Sep 29, 2022

Correcting a mistake I made when removing the test matrix code from #191540

I did not understand the impact of my correction. A real shame, because I've spent a lot of time assuring that the original PR didn't break anything (except the new nixos/lib runTest use case, which wasn't nearly as important...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roberth @vcunat