check-meta: Add isHydraChannel#193310
Merged
sternenseemann merged 1 commit intoNixOS:masterfrom Sep 28, 2022
Merged
Conversation
aszlig
requested review from
Ericson2314,
matthewbauer and
piegamesde
as code owners
This is needed in order to mark a certain derivation containing a Nix expression tarball to Hydra so that it is recognised as a channel. When I first got an evaluation error due to using this meta attribute, I was under the impression that nobody outside of Vuizvui[1] is using this feature and that we don't have any occurrence of isHydraChannel in Nixpkgs. However, when working around[2] the issue I assumed that it's not something that should be included in Nixpkgs because we're not using it there. It turned out that my assumption was wrong and we *do* use the attribute in Nixpkgs, namely via releaseTools.channel, which is similar to what we're doing in Vuizvui. Since we already include a bunch of undocumented attributes in metaTypes, it only makes sense to add isHydraChannel as well since it's actually documented in the Hydra documentation[3]. [1]: https://github.com/openlab-aux/vuizvui [2]: openlab-aux/vuizvui@e0685e81b3fdc43a272f0 [3]: https://github.com/NixOS/hydra/blob/53335323ae79ca1a42643f58e520b376898ce641/doc/manual/src/jobs.md#meta-fields Signed-off-by: aszlig <aszlig@nix.build>
aszlig
force-pushed
the
meta-is-hydra-channel
branch
from
4652213 to
612c140
Compare
sternenseemann
approved these changes
Sep 28, 2022
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed in order to mark a certain derivation containing a Nix expression tarball to Hydra so that it is recognised as a channel.
When I first got an evaluation error due to using this meta attribute, I was under the impression that nobody outside of Vuizvui1 is using this feature and that we don't have any occurrence of isHydraChannel in Nixpkgs.
However, when working around2 the issue I assumed that it's not something that should be included in Nixpkgs because we're not using it there.
It turned out that my assumption was wrong and we do use the attribute in Nixpkgs, namely via releaseTools.channel, which is similar to what we're doing in Vuizvui.
Since we already include a bunch of undocumented attributes in metaTypes, it only makes sense to add isHydraChannel as well since it's actually documented in the Hydra documentation3.
Footnotes
https://github.com/openlab-aux/vuizvui ↩
https://github.com/openlab-aux/vuizvui/commit/e0685e81b3fdc43a272f0 ↩
https://github.com/NixOS/hydra/blob/53335323ae79ca1a42643f58e520b376898ce641/doc/manual/src/jobs.md#meta-fields ↩