Skip to content

tomlplusplus: init at 3.2.0#193038

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Scrumplex:add-tomlplusplus
Oct 18, 2022
Merged

tomlplusplus: init at 3.2.0#193038
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Scrumplex:add-tomlplusplus

Conversation

@Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Sep 26, 2022 •
edited
Loading

tomlplusplus is a header-only C++ library for parsing and serializing TOML files.

Repology

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Scrumplex
maintainers: add Scrumplex
07acee5 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 26, 2022
tobim
tobim approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Scrumplex Scrumplex requested a review from tobim October 3, 2022 11:50
@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 3, 2022
Minion3665
Minion3665 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Minion3665 Minion3665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-picked this into my local nixpkgs for a derivation I'm building and it seems to work fine. LGTM

@Minion3665 Minion3665 added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 18, 2022
@Minion3665 Minion3665 mentioned this pull request Oct 18, 2022
Merged
17 tasks
@LunNova
Copy link
Member

LunNova commented Oct 18, 2022

nixpkgs-review run:

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/193038

1 package built:
tomlplusplus

LunNova
LunNova approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@LunNova LunNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion to use the tag, will make no difference to build result.

@Scrumplex
tomlplusplus: init at 3.2.0
af41162 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@LunNova LunNova added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 18, 2022
@nixos-discourse
Copy link

nixos-discourse commented Oct 18, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/644

@SuperSandro2000 SuperSandro2000 merged commit 8042203 into NixOS:master Oct 18, 2022
@Minion3665 Minion3665 mentioned this pull request Oct 19, 2022
Merged
13 tasks
@Scrumplex Scrumplex deleted the add-tomlplusplus branch September 6, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova approved these changes

+2 more reviewers

@tobim tobim tobim approved these changes

@Minion3665 Minion3665 Minion3665 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Scrumplex @LunNova @nixos-discourse @tobim @Minion3665 @SuperSandro2000 @bobby285271