Skip to content

clang: specify meta.mainProgram #193004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 1 commit into from
Dec 4, 2022
Merged

clang: specify meta.mainProgram #193004

SuperSandro2000 merged 1 commit into from
Dec 4, 2022

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Sep 26, 2022 •
edited
Loading

Description of changes

This patch adds meta.mainProgram = "clang"; attribute to every versions of clang, and thus enable nix run clang and nix run clang-unwrapped.

This patch affects the meta attributes only and causes no Clang rebuild, making it trivial to merge.

This patch should be ready for backport.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 26, 2022
@nixos-discourse
Copy link

nixos-discourse commented Dec 4, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1507

@SuperSandro2000 SuperSandro2000 merged commit cb170c2 into NixOS:master Dec 4, 2022
@ShamrockLee ShamrockLee deleted the clang-mainprogram branch December 4, 2022 22:09
@ShamrockLee ShamrockLee mentioned this pull request Dec 5, 2022
Merged
13 tasks
@rrbutani rrbutani mentioned this pull request Jan 8, 2023
Merged
92 tasks
rrbutani added a commit to rrbutani/nixpkgs that referenced this pull request Jan 8, 2023
@rrbutani
llvmPackages_15: apply some patches from llvmPackages_14
8c4b8b5 
See NixOS#194634 for details.

PRs:
  - NixOS#191372
  - NixOS#190936
  - NixOS#82131
  - NixOS#199844
  - NixOS#197674
  - NixOS#184408
  - NixOS#193004
ElvishJerricco pushed a commit to ElvishJerricco/nixpkgs that referenced this pull request Jan 8, 2023
@rrbutani @ElvishJerricco
llvmPackages_15: apply some patches from llvmPackages_14
f3377f0 
See NixOS#194634 for details.

PRs:
  - NixOS#191372
  - NixOS#190936
  - NixOS#82131
  - NixOS#199844
  - NixOS#197674
  - NixOS#184408
  - NixOS#193004
rrbutani added a commit to rrbutani/nixpkgs that referenced this pull request Jan 10, 2023
@rrbutani
llvmPackages_15: apply some patches from llvmPackages_14
589713c 
See NixOS#194634 for details.

PRs:
  - NixOS#191372
  - NixOS#190936
  - NixOS#82131
  - NixOS#199844
  - NixOS#197674
  - NixOS#184408
  - NixOS#193004
rrbutani added a commit to rrbutani/nixpkgs that referenced this pull request Jan 27, 2023
@rrbutani
llvmPackages_15: apply some patches from llvmPackages_14
81ef82a 
See NixOS#194634 for details.

PRs:
  - NixOS#191372
  - NixOS#190936
  - NixOS#82131
  - NixOS#199844
  - NixOS#197674
  - NixOS#184408
  - NixOS#193004
github-actions bot pushed a commit that referenced this pull request Jan 28, 2023
@rrbutani @github-actions
llvmPackages_15: apply some patches from llvmPackages_14
4fb7083 
See #194634 for details.

PRs:
  - #191372
  - #190936
  - #82131
  - #199844
  - #197674
  - #184408
  - #193004
(cherry picked from commit 81ef82a)
K900 pushed a commit that referenced this pull request Jan 28, 2023
@rrbutani @K900
llvmPackages_15: apply some patches from llvmPackages_14
87e4857 
See #194634 for details.

PRs:
  - #191372
  - #190936
  - #82131
  - #199844
  - #197674
  - #184408
  - #193004
xanderio pushed a commit to xanderio/nixpkgs that referenced this pull request Feb 13, 2023
@rrbutani @xanderio
llvmPackages_15: apply some patches from llvmPackages_14
871ab8d 
See NixOS#194634 for details.

PRs:
  - NixOS#191372
  - NixOS#190936
  - NixOS#82131
  - NixOS#199844
  - NixOS#197674
  - NixOS#184408
  - NixOS#193004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShamrockLee @nixos-discourse @SuperSandro2000