Skip to content

Gitlab tools#192813

Merged
Lassulus merged 3 commits intoNixOS:masterfrom
wucke13:gitlab-tools
Nov 4, 2022
Merged

Gitlab tools#192813
Lassulus merged 3 commits intoNixOS:masterfrom
wucke13:gitlab-tools

Conversation

@wucke13
Copy link
Contributor

@wucke13 wucke13 commented Sep 24, 2022

Description of changes

This includes a set of tools required to thoroughly integrate rust projects into GitLab:

  • gitlab-clippy, which allows to create a gitlab code quality reports from clippy lints
  • lcov_cobertura, which allows to convert llvm lcov coverage reports to the cobertura format required by GitLab
  • cargo-llvm-cov to generate lcov coverage data
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 24, 2022
@wucke13 wucke13 force-pushed the gitlab-tools branch 2 times, most recently from ecec64d to d351cd0 Compare September 24, 2022 20:20
@wucke13
Copy link
Contributor Author

wucke13 commented Sep 24, 2022

@GrahamcOfBorg build cargo-llvm-cov python3Packages.lcov_cobertura gitlab-clippy

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 24, 2022
@wucke13
Copy link
Contributor Author

wucke13 commented Sep 24, 2022

@DieracDelta you mentioned cargo-llvm-cov over in taiki-e/cargo-llvm-cov#152 . Maybe I can interest you in reviewing this PR which also includes cargo-llvm-cov?

@wucke13
Copy link
Contributor Author

wucke13 commented Nov 4, 2022

@Lassulus would you mind taking a look? 😺

@Lassulus
Copy link
Member

Lassulus commented Nov 4, 2022

Result of nixpkgs-review pr 192813 run on x86_64-linux 1

4 packages built:
  • cargo-llvm-cov
  • gitlab-clippy
  • python310Packages.lcov_cobertura
  • python39Packages.lcov_cobertura

@Lassulus Lassulus merged commit ec3c2c4 into NixOS:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants