electron apps: fix wayland window decorations

[PaulGrandperrin]

Using NIXOS_OZONE_WL=1 on a gnome wayland session results in missing window decorations.

The arguments recommended on ArchLinux fixes the issue: https://wiki.archlinux.org/title/Wayland#Electron

This PR only patches vscode but maybe it would make sense to apply this patch to all other pkgs using NIXOS_OZONE_WL.

[PaulGrandperrin]

Pinging the maintainers: @eadwu @Synthetica9 @maxeaubrey @bobby285271

[SuperSandro2000]

Pinging the maintainers: @eadwu @Synthetica9 @maxeaubrey @bobby285271

You don't need to ping them, ofborg does that already.

This PR only patches vscode but maybe it would make sense to apply this patch to all other pkgs using NIXOS_OZONE_WL.

Can we do --enable-features=UseOzonePlatform,WaylandWindowDecorations ?

[PaulGrandperrin]

You don't need to ping them, ofborg does that already.

Ok!

--enable-features=UseOzonePlatform,WaylandWindowDecorations

I tried and it does work, I'm not sure UseOzonePlatform is really needed though

[amaxine]

I think UseOzonePlatform is now enabled by default on recent enough electron releases. This PR seems fine, but I think having this for all electron apps would be better - e.g. 1password and Slack would probably benefit from having this too.

[PaulGrandperrin]

I think UseOzonePlatform is now enabled by default on recent enough electron releases.

It looks like so!

This PR seems fine, but I think having this for all electron apps would be better - e.g. 1password and Slack would probably benefit from having this too.

I can do that, should I push those changes to this PR or in another PR?

[PaulGrandperrin]

I think UseOzonePlatform is now enabled by default on recent enough electron releases.

From my tests, it is already activated by default on 22.05's version of electron

[amaxine]

Changing this PR to affect everything that uses NIXOS_OZONE_WL sounds good to me 🙂

[PaulGrandperrin]

I pushed a new commit modifying NIXOS_OZONE_WL everywhere to enable the same flags.
I didn't try all the applications though, I'll try a few

[PaulGrandperrin]

Apps that had the same issue and that were fixed by this patch:

• vscode
• signal
• slack (the decorations are buggy)
• micropad

Apps that didn't have this issue but still work the same:

• chromium
• google-chrome
• brave

I tried but couldn't test:

• discord (doesn't launch on wayland, before and after)
• jitsi-meet-electron (ignores wayland flags, before and after)

[turion]

I'd prefer either:

• pinging all maintainers of all affected apps here
  or
• only fixing vscode here (to be merged immediately), and all other apps in a separate PR (pinging all maintainers there, possibly takes longer to merge)

[SuperSandro2000]

This is basically a treewide change where we usually do not ping all maintainers because it would take to long or never be done. If all changed programs where tested this is awesome and in my opinion enough to merge this PR.

[amaxine]

Ditto, reviews from everyone are practically an impossibility.