Fix rabbitmq config decryption#192620
Merged
turion merged 3 commits intoNixOS:masterfrom Sep 28, 2022
Merged
Conversation
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Does RabbitMQ not (yet) support OpenSSL 3.0? Would be nice if we can switch there eventually. |
Member
Author
|
The RabbitMQ docs aren't explicit about the openssl dependency, but their Docker stuff is, and it's all OpenSSL 1.1. I agree. |
turion
reviewed
Sep 26, 2022
turion
approved these changes
Sep 26, 2022
Contributor
turion
left a comment
turion
left a comment
There was a problem hiding this comment.
Just a minor doc nitpick, but I think this is great!
bobby285271
added
12.approvals: 1
Fixes NixOS#192499, nixosTests.rabbitmq Reverts the openssl upgrade introduced in 0565276
roberth
force-pushed
the
issue-192499-fix-rabbitmq-config-decrypt
branch
from
b79cd65 to
0c797e0
Compare
turion
approved these changes
Sep 28, 2022
Member
Author
|
Thank you for the review @turion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
rabbitmq-server: Use openssl_1_1 to fix config decryption
Fixes #192499, nixosTests.rabbitmq
Reverts the effect of the openssl upgrade introduced in 0565276 #150093
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes