Skip to content

python3Packages.flask-security-too: fix build failure #192456

Merged
SuperSandro2000 merged 2 commits intoNixOS:staging-nextfrom
gador:flask-security-5.0.0_fix
Sep 23, 2022
Merged

python3Packages.flask-security-too: fix build failure #192456
SuperSandro2000 merged 2 commits intoNixOS:staging-nextfrom
gador:flask-security-5.0.0_fix

Conversation

@gador
Copy link
Member

@gador gador commented Sep 22, 2022

Description of changes

Fix the build issue with flask-security-too on staging-next #191339

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 22, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 22, 2022
@SuperSandro2000 SuperSandro2000 changed the title Flask security 5.0.0 fix python3Packages.flask-security-too: fix build failure Sep 22, 2022
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that LGTM

gador and others added 2 commits September 23, 2022 10:09
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@gador gador force-pushed the flask-security-5.0.0_fix branch from 6067b0f to cc2dcc1 Compare September 23, 2022 08:10
@gador
Copy link
Member Author

gador commented Sep 23, 2022

@SuperSandro2000 done 👍

@SuperSandro2000
Copy link
Member

@ofborg build python310Packages.flask-security-too python310Packages.flask-mailman

@SuperSandro2000 SuperSandro2000 merged commit f2f2065 into NixOS:staging-next Sep 23, 2022
@avinashkanaujiya
Copy link

avinashkanaujiya commented Jan 16, 2024

my nix-build started failing, with flask security too pkg, can anyone help me with it.

Package ‘python3.11-flask-security-too-5.3.3’ in /nix/store/8sk1p3f5q05wxi8n1g2c7jdiw48x83r3-nixos/nixos/pkgs/development/python-modules/flask-security-too/default.nix:128 is marked as broken, refusing to evaluate.

Tried to allowBroken pkg, but test cases failed for it

Anyway to know, which pkg needs it, so that I can remove it.

@gador
Copy link
Member Author

gador commented Jan 16, 2024

Please see #280556
It is fixed there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants