Skip to content

[22.05] firefox-unwrapped: 104.0.2 -> 105.0; firefox-esr-102-unwrapped: 102.2.0esr -> 102.3.0esr#192093

Merged
mweinelt merged 3 commits intoNixOS:release-22.05from
mweinelt:22.05/firefox
Sep 21, 2022
Merged

[22.05] firefox-unwrapped: 104.0.2 -> 105.0; firefox-esr-102-unwrapped: 102.2.0esr -> 102.3.0esr#192093
mweinelt merged 3 commits intoNixOS:release-22.05from
mweinelt:22.05/firefox

Conversation

@mweinelt
Copy link
Member

Backport #191990

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 20, 2022
@mweinelt
Copy link
Member Author

 0:18.85(B ERROR: Rust compiler 1.60.0 is too old.(B(B
 0:18.85(B (B(B
 0:18.85(B To compile Rust language sources please install at least(B(B
 0:18.85(B version 1.61.0 of the 'rustc' toolchain (or, if using nightly,(B(B
 0:18.85(B at least one version newer than 1.61.0) and make sure it is(B(B
 0:18.85(B first in your path.(B(B

@mweinelt mweinelt marked this pull request as draft September 20, 2022 15:47
@wizeman
Copy link
Member

wizeman commented Sep 20, 2022

I got this error:

0:10.65(B ERROR: Rust compiler 1.60.0 is too old.(B(B
 0:10.65(B (B(B
 0:10.65(B To compile Rust language sources please install at least(B(B
 0:10.65(B version 1.61.0 of the 'rustc' toolchain (or, if using nightly,(B(B
 0:10.65(B at least one version newer than 1.61.0) and make sure it is(B(B
 0:10.65(B first in your path.(B(B
 0:10.65(B (B(B
 0:10.65(B You can verify this by typing 'rustc --version'.(B(B
 0:10.65(B (B(B
 0:10.65(B If you have the 'rustup' tool installed you can upgrade(B(B
 0:10.65(B to the latest release by typing 'rustup update'. The(B(B
 0:10.65(B installer is available from https://rustup.rs/(B(B
 0:10.65(B (B(B
*** Fix above errors and then restart with "./mach build"

@ofborg ofborg bot requested a review from lovesegfault September 20, 2022 16:09
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 20, 2022
@ofborg ofborg bot requested review from edolstra, nbp, squalus and vcunat September 20, 2022 19:58
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 20, 2022
@vcunat vcunat marked this pull request as ready for review September 21, 2022 08:13
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both work for me. So far, at least.

@vcunat
Copy link
Member

vcunat commented Sep 21, 2022

The build times really are long nowadays. (since profiling, I presume)

@wizeman
Copy link
Member

wizeman commented Sep 21, 2022

firefox-unwrapped works for me, thanks!

@mweinelt
Copy link
Member Author

The build times really are long nowadays. (since profiling, I presume)

Two builds & profiling in between. Before pgo it was ~21 minutes for me. WIth pgo it's ~52 minutes.

@mweinelt mweinelt merged commit 9bdbbaa into NixOS:release-22.05 Sep 21, 2022
@mweinelt mweinelt deleted the 22.05/firefox branch September 21, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants