Skip to content

Comments

haskell.{compiler,packages}: Add aliases without minor versions#191991

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn:drop-minor-versions
Sep 21, 2022
Merged

haskell.{compiler,packages}: Add aliases without minor versions#191991
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn:drop-minor-versions

Conversation

@maralorn
Copy link
Member

Description of changes

We frequently have to bump a lot of references when a minor version of a ghc get’s released. These shorter names lead to less churn for us and downstream users.
By keeping the long version name we still have the option to have multiple versions at the same time and don‘t break any downstreams.

I fear that the change as is will do wrong things to hydra. Would appreciate feedback.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 20, 2022
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this before and I think we all agreed it would be nice to have these aliases.

Thanks!

Maybe if you're feeling generous you could also add a note about these additional aliases to the release notes (but even if you don't, I feel like no big deal, its not like these aliases would hurt anyone).

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 20, 2022
@maralorn
Copy link
Member Author

@sternenseemann do you think this is okay to throw at hydra or do we maybe need to add the new aliases to more blocklists to reduce the number of generated jobs?

@maralorn
Copy link
Member Author

I added a changelog entry.

@github-actions github-actions bot added the 8.has: changelog This PR adds or changes release notes label Sep 21, 2022
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 21, 2022
@bobby285271 bobby285271 removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 21, 2022
@maralorn
Copy link
Member Author

Oh, I think hydra should be fine since there is an explicit list of packages for which to create test jobs.

@maralorn maralorn merged commit e2c6425 into NixOS:haskell-updates Sep 21, 2022
@maralorn maralorn deleted the drop-minor-versions branch September 21, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants