haskell.{compiler,packages}: Add aliases without minor versions#191991
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Sep 21, 2022
Merged
haskell.{compiler,packages}: Add aliases without minor versions#191991maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
cdepillabout
approved these changes
Sep 20, 2022
Member
cdepillabout
left a comment
There was a problem hiding this comment.
We talked about this before and I think we all agreed it would be nice to have these aliases.
Thanks!
Maybe if you're feeling generous you could also add a note about these additional aliases to the release notes (but even if you don't, I feel like no big deal, its not like these aliases would hurt anyone).
Member
Author
|
@sternenseemann do you think this is okay to throw at hydra or do we maybe need to add the new aliases to more blocklists to reduce the number of generated jobs? |
c0ce664 to
fae2ff5
Compare
Member
Author
|
I added a changelog entry. |
Member
Author
|
Oh, I think hydra should be fine since there is an explicit list of packages for which to create test jobs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
We frequently have to bump a lot of references when a minor version of a ghc get’s released. These shorter names lead to less churn for us and downstream users.
By keeping the long version name we still have the option to have multiple versions at the same time and don‘t break any downstreams.
I fear that the change as is will do wrong things to hydra. Would appreciate feedback.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes