haskell-language-server: 1.7.0.0 -> 1.8.0.0#191987
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Sep 21, 2022
Merged
haskell-language-server: 1.7.0.0 -> 1.8.0.0#191987maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
Member
Author
|
Sadly not striving for local coherence apparently creates linking issues, at least when linking the hls for 9.0.2 statically. Now I fear that in the dynamically linked builds those linking issues could happen at runtime. I don‘t know enough about linking to tell if that’s true. Maybe we need another way … |
Member
Author
|
Update:
I am now satisfied with the quality of this PR and want to see hydra have a go at it. |
This was referenced Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This updates the package set to build haskell-language-server 1.8 successfully
on ghc 8.8, 8.10, 9.0 and 9.2.
The following design decisions have been made:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes