hedgewars: Disable autoupdate on darwin to fix build#191699
Closed
maralorn wants to merge 1 commit intoNixOS:haskell-updatesfrom
Closed
hedgewars: Disable autoupdate on darwin to fix build#191699maralorn wants to merge 1 commit intoNixOS:haskell-updatesfrom
maralorn wants to merge 1 commit intoNixOS:haskell-updatesfrom
Conversation
On darwin cmake complains about missing Sparkle. Autoupdates don‘t seem important for a nixpkgs package, so we disable it. See: https://hydra.nixos.org/build/190503204/nixlog/4 for the error.
Member
|
@ofborg build hedgewars |
Member
Author
|
As witnessed by ofBorg this just let’s the build proceed to another failure. |
Member
|
Unfortunately, I also can't test or fix this since I don't have Darwin either. I would propose to disable builds for Darwin for now. We should also disable the autoupdate in nixpkgs. 👍 |
Member
Author
|
If have done this in e678b76. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On darwin cmake complains about missing Sparkle. Autoupdates don‘t seem important for a nixpkgs package, so we disable it.
See: https://hydra.nixos.org/build/190503204/nixlog/4 for the error.
\cc @fpletz @kragniz
I can‘t test this on darwin, I will only be able to tell after merging.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes