Skip to content

resholve: use originalSrc for nixpkgs-update bot #191354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thiagokokada merged 1 commit into from
Sep 17, 2022
Merged

resholve: use originalSrc for nixpkgs-update bot #191354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/development/misc/resholve/resholve-utils.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ rec {
# retain a reference to the base
passthru = unresholved.passthru // {
unresholved = unresholved;
# fallback attr for update bot to query our src
originalSrc = unresholved.src;
Comment on lines +188 to +189
Copy link
Copy Markdown
Contributor

@thiagokokada thiagokokada Sep 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should document this somewhere. Looks like it could be useful for a few other use cases.

Copy link
Copy Markdown
Contributor

@thiagokokada thiagokokada Sep 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for this PR though.

Copy link
Copy Markdown
Member Author

@abathur abathur Sep 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should document this somewhere. Looks like it could be useful for a few other use cases.

I agree, though I'm at a bit of a loss for where since nixpkgs-update doesn't seem to be mentioned in the nixpkgs manual or the nixos wiki.

I feel like there could/should probably be a whole section there, or maybe a distinct guide, that covers the broad topic of propagating updates to nixpkgs. At least:

  • how to write and run update scripts both bespoke or via genericUpdater, nix-update-script, and any others
  • code-generation best-practices for nix-ecosystem projects that need to maintain an in-tree copy of code they develop out of tree
  • notes on the existence of the update bot, how to help it update your package, etc.

I have at least opened a PR over at nixpkgs-update to make it a little more discoverable: nix-community/nixpkgs-update#325

};

# do these imply that we should use NoCC or something?
Expand Down