haskellPackages.xmonad: drop upstreamed Nix compat patch#191169
Merged
sternenseemann merged 1 commit intoNixOS:haskell-updatesfrom Sep 14, 2022
Merged
haskellPackages.xmonad: drop upstreamed Nix compat patch#191169sternenseemann merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
sternenseemann
requested review from
cdepillabout and
maralorn
as code owners
github-actions
bot
added
the
6.topic: haskell
Member
Author
|
@ofborg build xmonad xmonadctl haskellPackages.xmonad-contrib |
Member
Author
|
@ofborg test xmonad Edit: ran out of disk space :( |
We had a long standing downstream patch for XMonad allowing us to override the ghc and xmessage binaries used. That has been upstreamed and released in 0.17.1 and we can drop it! * patch upstreamed in xmonad/xmonad#409 * downstream patch adjusted in NixOS#184784
sternenseemann
force-pushed
the
xmonad-0.17.1
branch
from
fe20750 to
8da11f8
Compare
Member
|
@ofborg eval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a long standing downstream patch for XMonad allowing us to override the ghc and xmessage binaries used. That has been upstreamed and released in 0.17.1 and we can drop it!
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes