haskellPackages.polysemy-zoo: fix dependencies#190058
Closed
kephas wants to merge 1 commit intoNixOS:haskell-updatesfrom
Closed
haskellPackages.polysemy-zoo: fix dependencies#190058kephas wants to merge 1 commit intoNixOS:haskell-updatesfrom
kephas wants to merge 1 commit intoNixOS:haskell-updatesfrom
Conversation
cdepillabout
requested changes
Sep 7, 2022
Member
There was a problem hiding this comment.
Thanks for taking the time to try to fix this.
Just a couple things:
- This
hackage-packages.nixfile is auto-generated, and will be overwritten if you edit it manually. Instead, you'll need to make changes in the other files in this this same directory (e.g.configuration-common.nixand others). - We generally try to have all Haskell-related PRs coming to the
haskell-updatesbranch. Could you rebase onhaskell-updatesand change the base branch here on GitHub? - The commit message and PR title should be
haskellPackages.polysemy-zoo: fix dependencies, sincepolysemy-zooisn't a top-level package. (This is sort of a nit-pick, but ofborg does use this info to test the package, so it is nice to get right).
Other comments inline.
Author
|
Thanks a lot for the instructions, they were very clear. Are the changes OK? I don't see how to change the branch that the PR is coming from, though, so I pushed |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes