Skip to content

Comments

haskellPackages.polysemy-zoo: fix dependencies#190058

Closed
kephas wants to merge 1 commit intoNixOS:haskell-updatesfrom
kephas:master
Closed

haskellPackages.polysemy-zoo: fix dependencies#190058
kephas wants to merge 1 commit intoNixOS:haskell-updatesfrom
kephas:master

Conversation

@kephas
Copy link

@kephas kephas commented Sep 6, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 6, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 6, 2022
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to try to fix this.

Just a couple things:

  • This hackage-packages.nix file is auto-generated, and will be overwritten if you edit it manually. Instead, you'll need to make changes in the other files in this this same directory (e.g. configuration-common.nix and others).
  • We generally try to have all Haskell-related PRs coming to the haskell-updates branch. Could you rebase on haskell-updates and change the base branch here on GitHub?
  • The commit message and PR title should be haskellPackages.polysemy-zoo: fix dependencies, since polysemy-zoo isn't a top-level package. (This is sort of a nit-pick, but ofborg does use this info to test the package, so it is nice to get right).

Other comments inline.

@kephas kephas changed the base branch from master to haskell-updates September 8, 2022 09:23
@kephas
Copy link
Author

kephas commented Sep 8, 2022

Thanks a lot for the instructions, they were very clear. Are the changes OK?

I don't see how to change the branch that the PR is coming from, though, so I pushed kephas:haskell-updates to kephas:master.

@kephas kephas changed the title polysemy-zoo: fix dependencies haskellPackages.polysemy-zoo: fix dependencies Sep 8, 2022
@kephas kephas requested review from cdepillabout and removed request for maralorn and sternenseemann September 23, 2022 15:32
@cdepillabout
Copy link
Member

Thanks! I cherry-picked this into haskell-updates at commit 72f01f1. You can see this in #192852.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants