vimPlugins.coc-spell-checker: use a node package#189788
Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom Nov 17, 2022
Merged
vimPlugins.coc-spell-checker: use a node package#189788SuperSandro2000 merged 2 commits intoNixOS:masterfrom
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Conversation
ofborg
bot
requested review from
Luflosi,
MarcWeber,
jagajaga,
midchildan and
winterqt
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
|
LGTM, please rebase and give me a ping for a quick merge. Maybe only commit the relevant lines to reduce the amount of noise and risk not another merge conflict? |
Minion3665
force-pushed
the
coc-spell-checker
branch
3 times, most recently
from
f339999 to
1702d51
Compare
ofborg
bot
added
the
2.status: merge conflict
Minion3665
force-pushed
the
coc-spell-checker
branch
2 times, most recently
from
c12d715 to
174da23
Compare
ofborg
bot
removed
the
2.status: merge conflict
Minion3665
force-pushed
the
coc-spell-checker
branch
from
174da23 to
cfa25dc
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
Author
@SuperSandro2000 thank you so much for helping! I've rebased, regenerated all the node packages and vim plugins, and taken your advice to commit only the necessary lines. I've run another nixpkgs-review so I believe this PR doesn't introduce any regressions and I've also tested that the coc-spell-checker plugin builds and works |
Minion3665
force-pushed
the
coc-spell-checker
branch
from
cfa25dc to
af8df70
Compare
Member
Author
|
(Another rebase as node-packages.nix changes very frequently. Maybe I'll make something to just upgrade only some packages there as it seems to need it, I've also run nixpkgs-review again to make sure I'm not introducing any regressions) |
- coc-spell-checker needs to be from nodePackages rather than generated as normal vim plugins are - this commit adds coc-spell-checker to nodePackages and adds an override to the vim plugin
- This node-packages.nix file in this commit was generated with ./pkgs/development/node-packages/generate.sh and then trimmed down in order to only commit the new package and dependencies Dependencies include: - @cspell/dict packages - Other cspell libraries - Some other JS libraries (e.g. comment-json) - The vim/plugins/generated.nix file in this commit was generated with ./pkgs/applications/editors/vim/plugins/update.py and then trimmed down in order to only commit the removal of coc-spell-checker being directly in there - This is to avoid large rebuilds (and make conflicts less likely)
Minion3665
force-pushed
the
coc-spell-checker
branch
from
340339e to
5fb4db7
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coc-spell-checker needs to be from nodePackages rather than generated
as normal vim plugins are
this commit adds coc-spell-checker to nodePackages and adds an
override to the vim plugin
A similar pull request is vimPlugins.coc-spell-checker: Add override and node dependency #83661, although that was dropped due to conflicts && an unresponsive author
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes