python3Packages.dateparser: patch flaky test#189312
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Sep 1, 2022
Merged
Conversation
The dateparser module has a test that works with the current day of the
month and uses it in June 2020. This breaks everytime we build the
package on the 31st of a month, because June only has 30 days.
```
❯ cal 6 2020
Juni 2020
Mo Di Mi Do Fr Sa So
1 2 3 4 5 6 7
8 9 10 11 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30
```
scrapinghub/dateparser#1053
github-actions
bot
added
the
6.topic: python
Member
Author
|
@ofborg build python3.pkgs.dateparser |
ofborg
bot
added
10.rebuild-darwin: 11-100
1 task
Contributor
|
Successfully created backport PR #189315 for |
Contributor
|
The process '/usr/bin/git' failed with exit code 1 |
1 similar comment
Contributor
|
The process '/usr/bin/git' failed with exit code 1 |
vcunat
added a commit
that referenced
this pull request
Oct 31, 2022
Our patch from PR #189312 wasn't complete; let's take the upstream one. I tested on 31st that it really passes now.
Member
|
Oh, it's 31st again 🤦🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dateparser module has a test that works with the current day of the
month and uses it in June 2020. This breaks everytime we build the
package on the 31st of a month.
scrapinghub/dateparser#1053
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes