Skip to content

Comments

haskellPackages.monad-bayes: Jailbreak for GHC 9.*#189234

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
turion:dev_monad_bayes
Sep 2, 2022
Merged

haskellPackages.monad-bayes: Jailbreak for GHC 9.*#189234
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
turion:dev_monad_bayes

Conversation

@turion
Copy link
Contributor

@turion turion commented Sep 1, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

I tested by building haskell.packages.ghc923.monad-bayes and haskellPackages.monad-bayes.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 1, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 1, 2022
@turion
Copy link
Contributor Author

turion commented Sep 2, 2022

@ofborg build haskell.packages.ghc924.monad-bayes haskell.packages.ghc942.monad-bayes haskell.packages.ghc902.monad-bayes

@turion
Copy link
Contributor Author

turion commented Sep 2, 2022

Ah, I cannot build these with borg it seems, because they are still marked broken?

@turion
Copy link
Contributor Author

turion commented Sep 2, 2022

On 9.4.2 it doesn't build anymore/yet because of dependency build failures (base-compat). On 9.0 and 9.2 it still builds.

@sternenseemann
Copy link
Member

On 9.4.2 it doesn't build anymore/yet because of dependency build failures (base-compat). On 9.0 and 9.2 it still builds.

Don't expect much on the 9.4 set, no time was spent on that so far. E.g. the base compat problem is probably already half-fixed by bumping its version. Right now 9.4 just uses the LTS-19 constraints.

@cdepillabout
Copy link
Member

LGTM, thanks!

@cdepillabout cdepillabout merged commit a427e34 into NixOS:haskell-updates Sep 2, 2022
@cdepillabout
Copy link
Member

In the future, feel free to run ./maintainers/scripts/haskell/regenerate-hackage-packages.sh to actually mark the package unbroken. It generally saves us a little bit of time.

@turion turion deleted the dev_monad_bayes branch September 3, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants