Skip to content

[22.05] backport haskell.packages.ghc924.hiedb: dontCheck#189082

Merged
sternenseemann merged 1 commit intoNixOS:release-22.05from
caryoscelus:backport-hiedb-dontcheck
Aug 31, 2022
Merged

[22.05] backport haskell.packages.ghc924.hiedb: dontCheck#189082
sternenseemann merged 1 commit intoNixOS:release-22.05from
caryoscelus:backport-hiedb-dontcheck

Conversation

@caryoscelus
Copy link
Contributor

Description of changes

backport from #184194 to make hiedb build under new GHC

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

(this is my first NixOS PR, hopefully it's simple enough that i didn't break anything :D)

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Aug 31, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 31, 2022
@cdepillabout
Copy link
Member

@ofborg build haskell.packages.ghc924.hiedb haskell-language-server

@sternenseemann
Copy link
Member

Backport commits should be created using cherry-pick -x, so it's easier to find the original commit (see the backporting guide). Can you please fix that and force-push to this branch?

@caryoscelus caryoscelus force-pushed the backport-hiedb-dontcheck branch from 8c38a7c to 59c915b Compare August 31, 2022 08:23
@caryoscelus
Copy link
Contributor Author

@sternenseemann done, thanks

@sternenseemann
Copy link
Member

@ofborg build haskell.packages.ghc923.hiedb haskell.packages.ghc924.hiedb

@sternenseemann sternenseemann merged commit e33722b into NixOS:release-22.05 Aug 31, 2022
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants