python3Packages.torch{,-bin}: rename from pytorch{,-bin}#188984
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Aug 30, 2022
Merged
python3Packages.torch{,-bin}: rename from pytorch{,-bin}#188984mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: ocaml
The proper name for a python package is the one in the setuptools setup() call, which can also be seen on pypi. Correct: https://pypi.org/project/torch/ Wrong: https://pypi.org/project/pytorch/ Includes a treewide rename of the attribute and creates aliases for the old name.
ofborg
bot
added
8.has: clean-up
samuela
reviewed
Aug 30, 2022
Member
samuela
left a comment
samuela
left a comment
There was a problem hiding this comment.
changes LGTM
will the packages still be discoverable on search.nixos.org when users search for "pytorch"?
Member
Author
|
If it's neither the pname nor part of the description I don't believe so. Probably something to take up with the search people? The official description would also need to be set to
I will do that on the 1.12.1 update that I have queued locally. |
Member
|
Yeah, in that case I propose we just add "PyTorch" into the description to aid discoverability. Eg, something like "The PyTorch machine learning framework. Tensors and Dynamic neural networks in Python with strong GPU acceleration" |
Member
Author
|
Description update is part of #189013 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proper name for a python package is the one in the setuptools
setup() call, which can also be seen on pypi.
Correct: https://pypi.org/project/torch/
Wrong: https://pypi.org/project/pytorch/
Includes a treewide rename of the attribute and creates aliases for the
old name.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes