Skip to content

haskellPackages.streaming-commons: Fix sandboxed build on Darwin#188247

Merged
expipiplus1 merged 1 commit intoNixOS:haskell-updatesfrom
centromere:fix-streaming-commons
Aug 25, 2022
Merged

haskellPackages.streaming-commons: Fix sandboxed build on Darwin#188247
expipiplus1 merged 1 commit intoNixOS:haskell-updatesfrom
centromere:fix-streaming-commons

Conversation

@centromere
Copy link
Member

Description of changes
Failures:

  test/Data/Streaming/NetworkSpec.hs:26:38:
  1) Data.Streaming.Network.bindRandomPortTCP sanity
       uncaught exception: IOException of type PermissionDenied
       Network.Socket.bind: permission denied (Operation not permitted)
       (after 1 test)
         ""

  To rerun use: --match "/Data.Streaming.Network/bindRandomPortTCP/sanity/"

Randomized with seed 1702276703

Finished in 15.4554 seconds
63 examples, 1 failure
Test suite test: FAIL
Test suite logged to: dist/test/streaming-commons-0.2.2.4-test.log
0 of 1 test suites (0 of 1 test cases) passed.
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 25, 2022
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Aug 25, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 25, 2022
@cdepillabout
Copy link
Member

Thanks!

Could you rebase this on the haskell-updates branch (and change the base here on GitHub as well)? We generally ask all Haskell-related changes to go into the haskell-updates branch.

@centromere centromere force-pushed the fix-streaming-commons branch from fd58fe1 to da501f8 Compare August 25, 2022 04:54
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 25, 2022
@centromere centromere changed the base branch from staging to haskell-updates August 25, 2022 04:56
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 25, 2022
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Aug 25, 2022
@ofborg ofborg bot requested review from doronbehar, expipiplus1 and guibou August 25, 2022 05:33
@ofborg ofborg bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 25, 2022
@expipiplus1
Copy link
Contributor

Thanks!

@expipiplus1 expipiplus1 merged commit 0e4a58c into NixOS:haskell-updates Aug 25, 2022
@centromere centromere deleted the fix-streaming-commons branch August 25, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants