vid-stab: 1.1.0 -> unstable-2022-05-30, fix linking against it with clang#188087
Merged
marsam merged 1 commit intoNixOS:masterfrom Sep 17, 2022
Merged
vid-stab: 1.1.0 -> unstable-2022-05-30, fix linking against it with clang#188087marsam merged 1 commit intoNixOS:masterfrom
marsam merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 11-100
…lang - vid-stab 1.1.0 (current release) hardcodes libgomp in its pkg-config. Current git version includes a commit fixing this, so this change updates to the git versions - placing openmp in `buildInputs` causes it not to be present when linking against vid-stab, causing linking to fail. Move it to `propagatedBuildInputs` to resolve - the all-packages.nix change enables vid-stab in (for example) ffmpeg on macos (where it was previously disabled).
codyps
changed the title
Contributor
|
Result of 4 packages marked as broken and skipped:
7 packages failed to build:
49 packages built:
|
Contributor
Author
|
Result of 14 packages marked as broken and skipped:
2 packages failed to build:
6 packages built:
|
Contributor
Author
|
Result of 4 packages marked as broken and skipped:
6 packages failed to build:
50 packages built:
|
Contributor
Author
|
FWIW:
These are broken-by-default due to needing manually fetched src:
These were already broken:
|
Contributor
|
Not sure what the process is here then. Should these be explicitly marked as broken? |
Janik-Haag
added
the
12.first-time contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current git version includes a commit fixing this, so this change
updates to the git versions
buildInputscauses it not to be present whenlinking against vid-stab, causing linking to fail. Move it to
propagatedBuildInputsto resolveon macos (where it was previously disabled).
Description of changes
Changes: georgmartius/vid.stab@60d65da...90c76ac
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes