nodejs_18: fix eval

[SuperSandro2000]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[ajs124]

This probably just hides the issue and makes it harder debug actual problems. here you say "This broke eval for node 18", but what exactly is that supposed to mean? Even without your PR here nix-instantiate -A nodejs-18_x works just fine.

The trace suggest you're talking about element-desktop. It would have been helpful if you actually said that.

Reverting d1b2156 is probably what should have been done instead. That commit most likely became unnecessary/wrong after recent changes to element.

So I suggest reverting this PR as well as d1b2156 and will do so if I don't get any more details.

[ajs124]

So I suggest reverting this PR as well as d1b2156 and will do so if I don't get any more details.

see #187783

[SuperSandro2000]

Yeah, sure. Sounds like the right approach to me.