Skip to content

haskell-language-server: fix with ghc-lib >= 9.0 and ghc <= 8.10.7#187284

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
wireapp:hls-hlint-plugin-workaround
Aug 18, 2022
Merged

haskell-language-server: fix with ghc-lib >= 9.0 and ghc <= 8.10.7#187284
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
wireapp:hls-hlint-plugin-workaround

Conversation

@flokli
Copy link
Member

@flokli flokli commented Aug 18, 2022

This cherry-picks the relevant changes from
haskell/haskell-language-server#2854 into the
8.10.x version of hls-hlint-plugin, as suggested in
#168064 (comment)

I built haskell-language-server.override { supportedGhcVersions = [ "8107" ]; } with that.

Fixes #168064.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from maralorn and mweinelt August 18, 2022 13:38
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Aug 18, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2022
@mweinelt mweinelt removed their request for review August 18, 2022 13:48
@smatting
Copy link
Contributor

smatting commented Aug 18, 2022

I sucessfully tested this branch with our 8.10.7 project: I added superfluous parens and got squiggly lines 👍

@cdepillabout
Copy link
Member

@flokli Thanks! Could you rebase this on haskell-updates? We generally ask haskell-related PRs to go to the haskell-updates branch.

This cherry-picks the relevant changes from
haskell/haskell-language-server#2854 into the
8.10.x version of hls-hlint-plugin, as suggested in
#168064 (comment)

Co-Authored-By: Florian Klink <flokli@flokli.de>
@flokli flokli changed the base branch from master to haskell-updates August 18, 2022 15:03
@flokli
Copy link
Member Author

flokli commented Aug 18, 2022

@cdepillabout I changed the base branch to haskell-updates.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Aug 18, 2022
@ofborg ofborg bot requested review from expipiplus1, fpletz, guibou and kragniz August 18, 2022 15:11
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2022
@ofborg ofborg bot removed the 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. label Aug 18, 2022
@cdepillabout
Copy link
Member

@ofborg build haskell.packages.ghc8107.hls-hlint-plugin

@cdepillabout
Copy link
Member

LGTM, thanks!

@cdepillabout cdepillabout merged commit f5cc833 into NixOS:haskell-updates Aug 18, 2022
@shinzui
Copy link

shinzui commented Aug 18, 2022

Thank you, @flokli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some plugins for haskell-language-server 8.10.7 are missing

4 participants