haskell-language-server: fix with ghc-lib >= 9.0 and ghc <= 8.10.7#187284
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Aug 18, 2022
wireapp:hls-hlint-plugin-workaround
Merged
haskell-language-server: fix with ghc-lib >= 9.0 and ghc <= 8.10.7#187284cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom wireapp:hls-hlint-plugin-workaround
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
wireapp:hls-hlint-plugin-workaround
Conversation
This was referenced Aug 18, 2022
Contributor
|
I sucessfully tested this branch with our 8.10.7 project: I added superfluous parens and got squiggly lines 👍 |
Member
|
@flokli Thanks! Could you rebase this on |
This cherry-picks the relevant changes from haskell/haskell-language-server#2854 into the 8.10.x version of hls-hlint-plugin, as suggested in #168064 (comment) Co-Authored-By: Florian Klink <flokli@flokli.de>
Member
Author
|
@cdepillabout I changed the base branch to |
Member
|
@ofborg build haskell.packages.ghc8107.hls-hlint-plugin |
Member
|
LGTM, thanks! |
|
Thank you, @flokli. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks the relevant changes from
haskell/haskell-language-server#2854 into the
8.10.x version of hls-hlint-plugin, as suggested in
#168064 (comment)
I built
haskell-language-server.override { supportedGhcVersions = [ "8107" ]; }with that.Fixes #168064.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes