Skip to content

gcc: drop unused libelf dependency#187234

Merged
trofi merged 1 commit intoNixOS:stagingfrom
trofi:drop-libelf-from-gcc
Aug 19, 2022
Merged

gcc: drop unused libelf dependency#187234
trofi merged 1 commit intoNixOS:stagingfrom
trofi:drop-libelf-from-gcc

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Aug 18, 2022 •
edited
Loading

gcc stopped using libelf in commit 48215350c24 ("re PR lto/46273 (Failed
to bootstrap)") around 2010, before gcc-4.6.0.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
gcc: drop unused libelf dependency
3b60b31 
gcc stopped using libelf in commit 48215350c24 ("re PR lto/46273 (Failed
to bootstrap)") around 2010, before gcc-4.6.0.
@trofi trofi requested a review from matthewbauer as a code owner August 18, 2022 07:37
@trofi trofi mentioned this pull request Aug 18, 2022
Merged
13 tasks
@ofborg ofborg bot added the 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. label Aug 18, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 18, 2022
@veprbl
Copy link
Member

veprbl commented Aug 18, 2022

@GrahamcOfBorg build gcc48 gcc49

@trofi trofi merged commit 7f458e5 into NixOS:staging Aug 19, 2022
@trofi trofi deleted the drop-libelf-from-gcc branch August 19, 2022 18:16
@trofi trofi mentioned this pull request Jul 15, 2025
Merged
13 tasks
trofi added a commit to trofi/nixpkgs that referenced this pull request Jul 16, 2025
@trofi
gccNGPackages_15.gcc: drop unused libelf dependency
6a74f38 
This mirrors the NixOS#187234 change
where `libelf` was removed from `gcc` packages. `libelf` is not used
by `gcc` since `4.6.0` version.
@trofi trofi mentioned this pull request Jul 16, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@veprbl veprbl Awaiting requested review from veprbl

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @veprbl