Skip to content

python3Packages.radon: init at 5.1.0#187154

Closed
jpetrucciani wants to merge 2 commits intoNixOS:masterfrom
jpetrucciani:jacobi_add_radon_py
Closed

python3Packages.radon: init at 5.1.0#187154
jpetrucciani wants to merge 2 commits intoNixOS:masterfrom
jpetrucciani:jacobi_add_radon_py

Conversation

@jpetrucciani
Copy link
Member

@jpetrucciani jpetrucciani commented Aug 17, 2022 •
edited
Loading

Description of changes

I would like to be able to use the radon (link here) code metrics tool inside of nixpkgs!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 17, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 18, 2022
onny
onny requested changes Aug 19, 2022
View reviewed changes
@jpetrucciani
Copy link
Member Author

jpetrucciani commented Aug 30, 2022

@onny not sure why it didn't update, but I've added something per your request

@jpetrucciani
Copy link
Member Author

jpetrucciani commented Jan 25, 2023

This has switched checkInputs to nativeCheckInputs to satisfy the recent tree-wide change (#206742)! It also adds changelog links, and specifies format = "setuptools"; explicitly for both packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onny onny onny requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpetrucciani @onny